0
Fork 0
mirror of https://github.com/ninenines/cowboy.git synced 2025-07-13 20:00:24 +00:00
Commit graph

2203 commits

Author SHA1 Message Date
Loïc Hoguin
a8c717718a
Update to most recent WebTransport draft
Some checks failed
Check Cowboy / Cleanup master build (push) Has been cancelled
Check Cowboy / Check examples (push) Has been cancelled
Check Cowboy / Cowboy (push) Has been cancelled
WEBTRANSPORT -> WT in most places. Only ENABLE_WEBTRANSPORT
remains (since it is a draft-02 setting that was later removed)
as well as internal functions and atoms about stream headers,
for greater clarity.

The draft also clarified that WT_SESSION_GONE can be sent on
the session stream and since it's what is already done a
related todo was removed.
2025-06-25 11:47:25 +02:00
Loïc Hoguin
5ec0eeb4d4
Depend on Cowlib master for WebTransport support
Some checks failed
Check Cowboy / Cleanup master build (push) Has been cancelled
Check Cowboy / Check examples (push) Has been cancelled
Check Cowboy / Cowboy (push) Has been cancelled
2025-06-20 13:37:10 +02:00
Loïc Hoguin
6b711124d7
Fix log printing error in examples_SUITE
A tool decided to use Unicode characters.
2025-06-20 12:27:13 +02:00
Loïc Hoguin
e5241620f5
Fix cowboy_http2 Dialyzer warnings with OTP-28 2025-06-20 11:50:38 +02:00
Loïc Hoguin
58909b0144
Initial WebTransport implementation
This implements the upcoming draft-13
but has bits to make it work with draft-02
that most (all?) Chromium versions use.

Data and events are not going through
cowboy_stream beyond init. Since this
approach appears to work well it may
be a good idea to do the same for
Websocket over HTTP/2+ and improve
its performance.
2025-06-19 16:27:07 +02:00
Loïc Hoguin
24d32de931
Update Cowboy version in user guide 2025-02-17 15:18:23 +01:00
Loïc Hoguin
eef66e0928
Remove copyright years from all files except LICENSE 2025-02-17 15:00:02 +01:00
Loïc Hoguin
d6dda1fee4
Relax Cowlib version requirement for Hex 2025-02-17 14:47:32 +01:00
Loïc Hoguin
9facbfd121
Cowboy 2.13.0 2025-02-17 14:46:20 +01:00
Loïc Hoguin
9430bf99ea
Use explicit Ranch and Cowlib versions 2025-02-17 12:57:00 +01:00
Loïc Hoguin
65a77a8f48
Use the new json module for the file_server example 2025-02-11 16:56:30 +01:00
Loïc Hoguin
761c1f8dca
Relax Ranch version requirement for Hex
It is now specified as >= 1.8.0 and < 3.0.0 since Cowboy
supports both Ranch 1.8.x and 2.x.
2025-02-11 16:02:10 +01:00
Loïc Hoguin
71b4147363
Improve the set_resp_headers_list test 2025-02-11 14:12:04 +01:00
Loïc Hoguin
e8a1868033
Add support for lists in cowboy_req:set_resp_headers
This is meant to be used with clients such as Gun to simplify
proxying and similar operations. The set-cookie header must
not be set this way so there is still some extra processing
to be done to fully translate a Gun response into a Cowboy
response.
2025-02-11 13:28:45 +01:00
Loïc Hoguin
f316a65906
cowboy_rest: Always set the Allow header
Not just on 405 responses or OPTIONS requests.
2025-02-10 18:41:11 +01:00
Loïc Hoguin
58402b4162
Remove unnecessary indirection in cowboy_rest 2025-02-10 18:11:05 +01:00
Loïc Hoguin
105d233c2e
Correct a ct_helper:ignore call 2025-02-10 17:24:13 +01:00
Loïc Hoguin
882a4f4591
Run http_SUITE:graceful_shutdown_listener separately
To avoid intermittent errors that are more likely as more
tests are calling cowboy:stop_listener.
2025-02-10 15:59:52 +01:00
Loïc Hoguin
053e233c56
Provide better control over which HTTP protocols are enabled
Over cleartext TCP the `protocols` option lists the enabled
protocols. The default is to allow both HTTP/1.1 and HTTP/2.

Over TLS the default protocol to use when ALPN is not used
can now be configured via the `alpn_default_protocol` option.

Performing an HTTP/1.1 upgrade to HTTP/2 over TLS is now
rejected with an error as connecting to HTTP/2 over TLS
requires the use of ALPN (or that HTTP/2 be the default
when connecting over TLS).
2025-02-10 15:26:00 +01:00
Loïc Hoguin
971684788d
Clarify that reverse/format_error constraint ops are experimental 2025-02-10 11:24:45 +01:00
Loïc Hoguin
72b57a846d
Detect invalid content_types_provided return values earlier
Before this change invalid return values would be detected
via unhelpful error messages such as [1] and the closing
of the connection.

[1] Bad value on output port 'tcp_inet'
2025-02-09 23:40:08 +01:00
Loïc Hoguin
fbd680f0f6
Properly handle external exits of request processes
Because the exit reason doesn't include the stacktrace they
were ignored. Now they are properly handled. The error message
was changed slightly to accomodate.
2025-02-08 14:53:54 +01:00
Loïc Hoguin
cc97c770fb
Deprecate the inactivity_timeout options
When idle_timeout is configured we do not need a separate
timer to detect inactivity. Disabling idle_timeout is not
recommended and should not be necessary.
2025-02-07 17:59:44 +01:00
Loïc Hoguin
dad67e19a1
Use maps:fold for cowboy_http's set_options for code clarity 2025-02-07 17:59:44 +01:00
Loïc Hoguin
0f257d06b6
Add hibernate option to cowboy_http and cowboy_http2
When enabled the connection process will automatically hibernate.
Because hibernation triggers GC, this can be used as a way to
keep memory usage lower, at the cost of performance.
2025-02-07 17:59:44 +01:00
Loïc Hoguin
d3f6bda38b
Fix unused variable warning 2025-02-06 15:10:12 +01:00
Loïc Hoguin
6753ed5815
Add an http_perf test uploading a 10GB body 2025-02-06 14:50:10 +01:00
Mirjam Friesen
36f42a5e8b
Fix cowboy_req:filter_cookies missing valid cookies
When 3 or more cookies were sent the extra cookies were not
found because the binary:split on ";" stopped at the first
occurrence.
2025-02-06 13:23:08 +01:00
Loïc Hoguin
8e121d138c
Fix request_timeout triggering when a request was in the buffer
The problem was that when a request immediately following another
request with a large enough body, the data for the new request
(including headers) would be buffered waiting for more data,
instead of being processed immediately. If no more data came
in on the socket the request_timeout would eventually trigger.
Now the buffer is processed immediately.
2025-02-06 12:18:59 +01:00
Loïc Hoguin
9d4912208e
Lower the lower dynamic buffer value to 1024
There's not a big performance difference between 8192 and 1024
so let's use less memory at the start of the connection.
2025-02-05 16:22:06 +01:00
Loïc Hoguin
073c481656
HTTP/1: Ensure active mode is enabled for the next stream
In rare cases it was possible for active mode to be disabled
when there were no streams pipelined. This resulted in the
dropping of the connection due to timeouts as no data could
be received.

We now enable active mode when necessary even if there are
no streams pipelined.

This was found while benchmarking and I have not been able
to extract a test case.
2025-02-05 14:30:25 +01:00
Loïc Hoguin
d889291c4f
Don't run perf suites by default 2025-02-05 14:30:25 +01:00
Loïc Hoguin
49be0f57cf
Implement dynamic socket buffer sizes
Cowboy will set the socket's buffer size dynamically to
better fit the current workload. When the incoming data
is small, a low buffer size reduces the memory footprint
and improves responsiveness and therefore performance.
When the incoming data is large, such as large HTTP
request bodies, a larger buffer size helps us avoid
doing too many binary appends and related allocations.

Setting a large buffer size for all use cases is
sub-optimal because allocating more than needed
necessarily results in a performance hit (not just
increased memory usage).

By default Cowboy starts with a buffer size of 8192 bytes.
It then doubles or halves the buffer size depending on
the size of the data it receives from the socket. It
stops decreasing at 8192 and increasing at 131072 by
default.

To keep track of the size of the incoming data Cowboy
maintains a moving average. It allows Cowboy to avoid
changing the buffer too often but still react quickly
when necessary. Cowboy will increase the buffer size
when the moving average is above 90% of the current
buffer size, and decrease when the moving average is
below 40% of the current buffer size.

The current buffer size and moving average are
propagated when switching protocols. The dynamic buffer
is implemented in HTTP/1, HTTP/2 and HTTP/1 Websocket.
HTTP/2 Websocket has it disabled because it doesn't
interact directly with the socket; in that case it
is HTTP/2 that has a dynamic buffer.

The dynamic buffer provides a very large performance improvement
in many scenarios, at minimal cost for others. Because it largely
depend on the underlying protocol the improvements are no all equal.
TLS and compression also impact the results.

The improvement when reading a large request body, with the
requests repeated in a fast loop are:

* HTTP: 6x to 20x faster
* HTTPS: 2x to 6x faster
* H2: 4x to 5x faster
* H2C: 20x to 40x faster

I am not sure why H2C's performance was so bad, especially compared
to H2, when using default buffer sizes. Dynamic buffers make H2C a
lot more viable with default settings.

The performance impact on "hello world" type requests is minimal,
it goes from -5% to +5% roughly.

Websocket improvements vary again depending on the protocol, but
also depending on whether compression is enabled:

* HTTP echo: roughly 2x faster
* HTTP send: roughly 4x faster
* H2C echo: roughly 2x faster
* H2C send: 3x to 4x faster

In the echo test we reply back, and Gun doesn't have the dynamic
buffer optimisation, so that probably explains the x2 difference.

With compression however there isn't much improvement. The results
are roughly within -10% to +10% of each other. Zlib compression
seems to be a bottleneck, or at least to modify the performance
profile to such an extent that the size of the buffer does not
matter. This happens to randomly generated binary data as well
so it is probably not caused by the test data.
2025-02-05 14:29:58 +01:00
David Ansari
fcab905eca
Cancel timers async
Where it wasn't already async. To slightly improve performance.
2025-01-24 13:06:29 +01:00
Loïc Hoguin
2531b26acf
Add initial http_perf_SUITE 2025-01-24 13:05:45 +01:00
Loïc Hoguin
05d77153a0
Fix supported OTP version in user guide 2025-01-23 15:09:18 +01:00
Marko Mindek
f071d772ed
Fix a few underspec'd types in cowboy_static 2025-01-23 15:07:10 +01:00
Björn Svensson
662f6af982
Correcting TransOpts in send_timeout_close tests 2025-01-23 13:29:47 +01:00
Jose M Perez
49061587be
Add WS compression test where only server sets client_max_window_bits
When the server has a non-default value configured and the client
doesn't send one the extension negotiation should fail.
2025-01-23 11:39:48 +01:00
Loïc Hoguin
7f739cad6d
Websocket: Also apply max_frame_size limit to decompressed data
Before this commit frames could "cheat" by compressing data
below the limit which would get expanded above the limit.
Now Cowboy will stop decompressing data when the limit is
reached.
2025-01-22 15:20:20 +01:00
Loïc Hoguin
6e221d38b1
Use cow_deflate in cowboy_decompress_h
The function inflate/3 was moved there to make it
usable from within Cowlib itself.
2025-01-22 15:20:16 +01:00
Loïc Hoguin
9d385fa909
Add compressed Websocket to ws_perf_SUITE 2025-01-22 11:32:56 +01:00
Loïc Hoguin
81de580aee
Websocket: Allow setting the max_frame_size option dynamically
This can be used to limit the maximum frame size before
some authentication or other validation is completed.
2025-01-16 14:47:20 +01:00
Loïc Hoguin
818b448ae9
Switch to running autobahntestsuite via Docker 2025-01-15 13:31:19 +01:00
Loïc Hoguin
1724575b42
Avoid resetting HTTP/2 idle_timeout timer too often
Following the same strategy as Websocket described in
commit cbed21c383e4cebb7df5a0a8b81f18c1738bef3e

Gains are comparable as far as Websocket over HTTP/2
is concerned.
2025-01-15 13:31:19 +01:00
Loïc Hoguin
086f60cca4
Avoid resetting Websocket idle_timeout timer too often
`perf` has shown that Cowboy spends a lot of time
cancelling and starting this timer. Instead of resetting
for every data received, we now only reset a field in the
state.

Before it was working like this:

- start idle timeout timer
- on trigger, close the connection
- on data, cancel and start again

Now it's working like this:

- start idle timeout timer for a tenth of its duration, with tick number = 0
- on trigger, if tick number != 10
  - start the timer again, again for a tenth of its duration
  - increment tick number
- on trigger, if tick number = 10
  - close the connection
- on data, set tick number to 0
2025-01-15 13:31:19 +01:00
Loïc Hoguin
643b335ba8
Add ws_perf_SUITE to measure Websocket performance
It benchmarks binary, ascii, mixed and japanese data
using Websocket and Websocket over HTTP/2.

HTTP/2 options get set to ensure that performance is
better than the default HTTP/2 options.

It switches to Gun and Ranch branches that include
fixes that are required for tests to complete successfully.
2025-01-15 13:28:57 +01:00
Loïc Hoguin
022013b6c4
Update Discord link to a permanent invite 2024-11-27 12:10:12 +01:00
Loïc Hoguin
e4762a6be3
Update CONTRIBUTING.asciidoc 2024-11-15 11:16:45 +01:00
Loïc Hoguin
c91f4d99ce
Add Discord server to README 2024-11-15 11:07:41 +01:00