umgeher/qdate
0
Fork 0
Code Issues Pull requests Releases Activity

Add some tests for new tz_database changes

Browse source
This commit is contained in:
Jesse Gumm 2016-01-31 09:07:54 -06:00
parent a443d476ac
commit 2d40869c1a
2 changed files with 16 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

6
rebar.config
View file

@ -1,14 +1,12 @@
%% -*- erlang -*-
%% vim:ts=4 sw=4 et ft=erlang
{require_otp_vsn, "R13B04|R14|R15|R16|17|18"}.
{cover_enabled, true}.
%% For rebar2 compat
{deps,
[
{erlware_commons, ".*", {git, "git://github.com/erlware/erlware_commons.git", {branch, master}}},
{erlang_localtime, ".*", {git, "git://github.com/choptastic/erlang_localtime.git", {branch, master}}}
{erlware_commons, ".*", {git, "git://github.com/erlware/erlware_commons.git", {tag, "v0.15.0"}}},
{erlang_localtime, ".*", {git, "git://github.com/choptastic/erlang_localtime.git", {branch, 'merged-gmt-fix'}}}
]}.
%% for rebar3

14
src/qdate.erl
View file

@ -752,6 +752,20 @@ tz_tests(_) ->
?_assertEqual({{2013,3,6},{18,0,0}}, to_date("GMT","3/7/2013 12:00am +0600")),
?_assertEqual({{2013,3,6},{12,0,0}}, to_date("CST","3/7/2013 12:00am +0600")),
%% These next two test check to make sure that the tz database properly
%% interprets GMT+/-X timezones (an earlier issue with
%% erlang_localtime's tz database had it incrementing/decrementing the
%% minute field rather than hours.
%%
%% It also ensures that GMT+/-X handling is interpreted the way you'd
%% intuitively expect, rather than the POSIX way, which is, quite
%% frankly, broken.
?_assertEqual({{2013,3,7},{10,0,0}}, to_date("GMT-0","3/7/2013 10:00am GMT")),
?_assertEqual({{2013,3,7},{10,0,0}}, to_date("GMT+0","3/7/2013 10:00am GMT")),
?_assertEqual({{2013,3,7},{9,0,0}}, to_date("GMT-1","3/7/2013 10:00am GMT")),
?_assertEqual({{2013,3,7},{11,0,0}}, to_date("GMT+1","3/7/2013 10:00am GMT")),
%% parsing, then reformatting the same time with a different timezone using the php "r" (rfc2822)
?_assertEqual("Thu, 07 Mar 2013 12:15:00 -0600",
to_string("r","CST",to_string("r","EST",{{2013,3,7},{13,15,0}}))),