From 0dda129d3e3ec8025351d76877a33c65e17dbd90 Mon Sep 17 00:00:00 2001
From: Martin Sumner <martin.sumner@adaptip.co.uk>
Date: Thu, 21 Jun 2018 15:46:42 +0100
Subject: [PATCH] Fix bad specs

There were some bad specs in '|' OR'd specs.  These were being falsely ignored in dialyzer until https://github.com/erlang/otp/pull/1722.

Running on OTP21 exposed these incomplete specs.
---
 src/leveled_codec.erl     | 4 ++--
 src/leveled_pmanifest.erl | 5 +++--
 2 files changed, 5 insertions(+), 4 deletions(-)

diff --git a/src/leveled_codec.erl b/src/leveled_codec.erl
index 1635bc4..2386336 100644
--- a/src/leveled_codec.erl
+++ b/src/leveled_codec.erl
@@ -88,7 +88,7 @@
 -type ledger_status() ::
         tomb|{active, non_neg_integer()|infinity}.
 -type ledger_key() :: 
-        {tag(), any(), any(), any()}.
+        {tag(), any(), any(), any()}|all.
 -type ledger_value() :: 
         {integer(), ledger_status(), segment_hash(), tuple()|null}.
 -type ledger_kv() ::
@@ -647,7 +647,7 @@ aae_indexspecs(AAE, Bucket, Key, SQN, H, LastMods) ->
     end.
 
 -spec parse_date(tuple(), integer(), integer(), integer()) ->
-                    no_index|{binary(), integer()}.
+                    no_index|{list(), integer()}.
 %% @doc
 %% Parse the last modified date and the AAE date configuration to return a
 %% binary to be used as the last modified date part of the index, and an
diff --git a/src/leveled_pmanifest.erl b/src/leveled_pmanifest.erl
index 51eb3bb..750cda9 100644
--- a/src/leveled_pmanifest.erl
+++ b/src/leveled_pmanifest.erl
@@ -79,8 +79,9 @@
 
 -type manifest() :: #manifest{}.
 -type manifest_entry() :: #manifest_entry{}.
+-type manifest_owner() :: pid()|list().
 
--export_type([manifest/0, manifest_entry/0]).
+-export_type([manifest/0, manifest_entry/0, manifest_owner/0]).
 
 %%%============================================================================
 %%% API
@@ -324,7 +325,7 @@ get_manifest_sqn(Manifest) ->
     Manifest#manifest.manifest_sqn.
 
 -spec key_lookup(manifest(), integer(), leveled_codec:ledger_key()) 
-                                                    -> false|manifest_entry().
+                                                    -> false|manifest_owner().
 %% @doc
 %% For a given key find which manifest entry covers that key at that level,
 %% returning false if there is no covering manifest entry at that level.