umgeher/leveled
0
Fork 0
Code Issues Pull requests Releases Activity Actions

Switch to checking on get_kvrange

Browse source 
In production scale testing, placing te check_modified call on get_kvrange not get_slots made the performance difference.

It should help in get_lots as well, but unable to reliably get coverage in tests with this.  So for now, will leave off until a proper test can be constructed which demonstrates any benefits.
This commit is contained in:
Martin Sumner 2020-12-03 13:37:22 +00:00
parent a210aa6846
commit f3f574de02
2 changed files with 125 additions and 24 deletions
Download patch file Download diff file Expand all files Collapse all files

36
src/leveled_sst.erl
View file

@ -689,10 +689,19 @@ reader({get_kv, LedgerKey, Hash}, _From, State) ->
timings_countdown = CountDown}};
reader({get_kvrange, StartKey, EndKey, ScanWidth, SegList, LowLastMod},
_From, State) ->
ReadNeeded =
check_modified(State#state.high_modified_date,
LowLastMod,
State#state.index_moddate),
{NeedBlockIdx, SlotsToFetchBinList, SlotsToPoint} =
fetch_range(StartKey, EndKey, ScanWidth,
case ReadNeeded of
true ->
fetch_range(StartKey, EndKey, ScanWidth,
SegList, LowLastMod,
State),
State);
false ->
{false, [], []}
end,
PressMethod = State#state.compression_method,
IdxModDate = State#state.index_moddate,
@ -727,23 +736,14 @@ reader({get_kvrange, StartKey, EndKey, ScanWidth, SegList, LowLastMod},
reader({get_slots, SlotList, SegList, LowLastMod}, _From, State) ->
PressMethod = State#state.compression_method,
IdxModDate = State#state.index_moddate,
ReadNeeded =
check_modified(State#state.high_modified_date,
LowLastMod,
State#state.index_moddate),
{NeedBlockIdx, SlotBins} =
case ReadNeeded of
true ->
read_slots(State#state.handle,
SlotList,
{SegList,
LowLastMod,
State#state.blockindex_cache},
State#state.compression_method,
State#state.index_moddate);
false ->
{false, []}
end,
read_slots(State#state.handle,
SlotList,
{SegList,
LowLastMod,
State#state.blockindex_cache},
State#state.compression_method,
State#state.index_moddate),
{reply,
{NeedBlockIdx, SlotBins, PressMethod, IdxModDate},
reader,