umgeher/leveled
0
Fork 0
Code Issues Pull requests Releases Activity Actions

Need to support undefined max penciller cache size

Browse source 
Without first converting it to the minimum.  So catch the undefined, at set_default
This commit is contained in:
Martin Sumner 2018-09-14 10:36:10 +01:00
parent 534bf87a51
commit e18d681043
1 changed files with 5 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

7
src/leveled_bookie.erl
View file

@ -93,6 +93,8 @@
-define(CACHE_SIZE, 2500). -define(CACHE_SIZE, 2500).
-define(MIN_CACHE_SIZE, 100). -define(MIN_CACHE_SIZE, 100).
-define(MIN_PCL_CACHE_SIZE, 400). -define(MIN_PCL_CACHE_SIZE, 400).
-define(MAX_PCL_CACHE_SIZE, 28000).
% This is less than actual max - but COIN_SIDECOUNT
-define(SNAPSHOT_TIMEOUT, 300000). -define(SNAPSHOT_TIMEOUT, 300000).
-define(CACHE_SIZE_JITTER, 25). -define(CACHE_SIZE_JITTER, 25).
-define(JOURNAL_SIZE_JITTER, 20). -define(JOURNAL_SIZE_JITTER, 20).
@ -117,7 +119,7 @@
{singlefile_compactionpercentage, 50.0}, {singlefile_compactionpercentage, 50.0},
{maxrunlength_compactionpercentage, 70.0}, {maxrunlength_compactionpercentage, 70.0},
{reload_strategy, []}, {reload_strategy, []},
{max_pencillercachesize, undefined}, {max_pencillercachesize, ?MAX_PCL_CACHE_SIZE},
{compression_method, ?COMPRESSION_METHOD}, {compression_method, ?COMPRESSION_METHOD},
{compression_point, ?COMPRESSION_POINT}]). {compression_point, ?COMPRESSION_POINT}]).
@ -283,7 +285,7 @@
{max_pencillercachesize, pos_integer()|undefined} | {max_pencillercachesize, pos_integer()|undefined} |
% How many ledger keys should the penciller retain in memory % How many ledger keys should the penciller retain in memory
% between flushing new level zero files. % between flushing new level zero files.
% Defaults to leveled_penciller:?MAX_TABLESIZE when undefined % Defaults to ?MAX_PCL_CACHE_SIZE when undefined
% The minimum size 400 - attempt to set this vlaue lower will be % The minimum size 400 - attempt to set this vlaue lower will be
% ignored. As a rule the value should be at least 4 x the Bookie's % ignored. As a rule the value should be at least 4 x the Bookie's
% cache size % cache size
@ -2504,6 +2506,7 @@ small_cachesize_test() ->
{cache_size, 1}]), {cache_size, 1}]),
ok = leveled_bookie:book_close(Bookie1). ok = leveled_bookie:book_close(Bookie1).
is_empty_test() -> is_empty_test() ->
RootPath = reset_filestructure(), RootPath = reset_filestructure(),
{ok, Bookie1} = book_start([{root_path, RootPath}, {ok, Bookie1} = book_start([{root_path, RootPath},