umgeher/leveled
0
Fork 0
Code Issues Pull requests Releases Activity Actions

Enhance unit tests for corruped segment filters

Browse source
This commit is contained in:
martinsumner 2016-10-24 11:44:28 +01:00
parent c78b5bca7d
commit d988c66ac6
2 changed files with 53 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

9
src/leveled_bookie.erl
View file

@ -186,6 +186,15 @@ book_riakput(Pid, RiakObject, IndexSpecs) ->
book_put(Pid, Bucket, Key, Object, IndexSpecs) ->
book_put(Pid, Bucket, Key, Object, IndexSpecs, ?STD_TAG).
%% TODO:
%% It is not enough simply to change the value to delete, as the journal
%% needs to know the key is a tombstone at compaction time, and currently at
%% compaction time the clerk only knows the Key and not the Value.
%%
%% The tombstone cannot be removed from the Journal on compaction, as the
%% journal entry the tombstone deletes may not have been reaped - and so if the
%% ledger got erased, the value would be resurrected.
book_riakdelete(Pid, Bucket, Key, IndexSpecs) ->
book_put(Pid, Bucket, Key, delete, IndexSpecs, ?RIAK_TAG).