Improve perf_SUITE test (#445)

* Improve perf_SUITE test

The update teat is refactored so as not to generate. a large KV list which dominates the memory utilisation.

The update and the get tests changes to do a head before each operation - which emulates how this will work in RIAK.

* Revert default setting change

* Don't pre-calculate key list

For fetches - reduces memory required for test process not database (and consequent distortion to measured results)

* Tidy ++ in tests

Removes some rogue results from profile

* Update testutil.erl

* Test fixes

* Tidy generate_chunk for profiling

* Revert "Tidy generate_chunk for profiling"

This reverts commit 1f6cff446ca6b9855f1e3aa732b32e0e5c14c9a5.

* Resize profile test

src/leveled_ebloom.erl

@@ -302,13 +302,7 @@ split_builder_speed_tester() ->
     Timings =
         lists:map(
             fun(HashList) ->
-                SlotCount =
-                    case length(HashList) of
-                        0 ->
-                            0;
-                        L ->
-                            min(128, max(2, (L - 1) div 512))
-                    end,
+                SlotCount = min(128, max(2, (length(HashList) - 1) div 512)),
                 InitTuple = list_to_tuple(lists:duplicate(SlotCount, [])),
                 {MTC, SlotHashes} =
                     timer:tc(

src/leveled_head.erl

@@ -32,8 +32,12 @@
             ]).
 
 %% Exported for testing purposes
--export([riak_metadata_to_binary/2,
-            riak_extract_metadata/2]).
+-export(
+    [
+        riak_metadata_to_binary/2,
+        riak_extract_metadata/2,
+        get_indexes_from_siblingmetabin/2
+    ]).
 
 
 -define(MAGIC, 53). % riak_kv -> riak_object

src/leveled_pmanifest.erl

@@ -74,7 +74,7 @@
             % At o(10) trillion keys behaviour may become increasingly 
             % difficult to predict.
 
--if(OTP_RELEASE >= 25).
+-if(?OTP_RELEASE >= 25).
 -if(length(?LEVEL_SCALEFACTOR) /= ?MAX_LEVELS).
 -error("length ?LEVEL_SCALEFACTOR differs from ?MAX_LEVELS").
 -endif.

test/end_to_end/perf_SUITE.erl

@@ -9,6 +9,7 @@
 -define(PEOPLE_INDEX, <<"people_bin">>).
 -define(MINI_QUERY_DIVISOR, 8).
 -define(RGEX_QUERY_DIVISOR, 32).
+-define(PUT_PAUSE, 40).
 
 -ifndef(performance).
   -define(performance, riak_ctperf).
@@ -92,13 +93,13 @@ riak_load_tester(Bucket, KeyCount, ObjSize, ProfileList, PM, LC) ->
         fun(ListID) ->
             fun() ->
                 RandInt = leveled_rand:uniform(IndexCount - 1),
-                IntIndex = "integer" ++ integer_to_list(ListID) ++ "_int",
-                BinIndex = "binary" ++ integer_to_list(ListID) ++ "_bin",
-                [{add, list_to_binary(IntIndex), RandInt},
+                IntIndex = ["integer", integer_to_list(ListID), "_int"],
+                BinIndex = ["binary", integer_to_list(ListID), "_bin"],
+                [{add, iolist_to_binary(IntIndex), RandInt},
                 {add, ?PEOPLE_INDEX, list_to_binary(random_people_index())},
-                {add, list_to_binary(IntIndex), RandInt + 1},
-                {add, list_to_binary(BinIndex), <<RandInt:32/integer>>},
-                {add, list_to_binary(BinIndex), <<(RandInt + 1):32/integer>>}]
+                {add, iolist_to_binary(IntIndex), RandInt + 1},
+                {add, iolist_to_binary(BinIndex), <<RandInt:32/integer>>},
+                {add, iolist_to_binary(BinIndex), <<(RandInt + 1):32/integer>>}]
             end
         end,
 
@@ -140,7 +141,7 @@ riak_load_tester(Bucket, KeyCount, ObjSize, ProfileList, PM, LC) ->
     GetMemoryTracker = memory_tracking(get, 1000),
     GetAccountant = accounting(get, 3000, ProfileList),
     TotalGetTime = 
-        random_fetches(get, Bookie1, Bucket, KeyCount, GetFetches),
+        random_fetches(riakget, Bookie1, Bucket, KeyCount div 2, GetFetches),
     ok = stop_accounting(GetAccountant),
     {MT2, MP2, MB2} = stop_tracker(GetMemoryTracker),
 
@@ -235,7 +236,7 @@ riak_load_tester(Bucket, KeyCount, ObjSize, ProfileList, PM, LC) ->
     UpdateMemoryTracker = memory_tracking(update, 1000),
     UpdateAccountant = accounting(update, 1000, ProfileList),
     TotalUpdateTime =
-        rotate_chunk(Bookie1, <<"UpdBucket">>, KeyCount div 50, ObjSize),
+        rotate_chunk(Bookie1, <<"UpdBucket">>, KeyCount div 100, ObjSize, 2),
     ok = stop_accounting(UpdateAccountant),
     {MT6, MP6, MB6} = stop_tracker(UpdateMemoryTracker),
 
@@ -360,29 +361,103 @@ profile_app(Pids, ProfiledFun, P) ->
 
     eprof:stop_profiling(),
     eprof:log(atom_to_list(P) ++ ".log"),
-    eprof:analyze(total, [{filter, [{time, 150000}]}]),
+    eprof:analyze(total, [{filter, [{time, 160000}]}]),
     eprof:stop(),
     {ok, Analysis} = file:read_file(atom_to_list(P) ++ ".log"),
     io:format(user, "~n~s~n", [Analysis])
     .
 
-rotate_chunk(Bookie, Bucket, KeyCount, ObjSize) ->
+rotate_chunk(Bookie, Bucket, KeyCount, ObjSize, IdxCount) ->
     ct:log(
         ?INFO,
         "Rotating an ObjList ~w - "
         "time includes object generation",
         [KeyCount]),
-    V1 = base64:encode(leveled_rand:rand_bytes(ObjSize)),
-    V2 = base64:encode(leveled_rand:rand_bytes(ObjSize)),
-    V3 = base64:encode(leveled_rand:rand_bytes(ObjSize)),
     {TC, ok} = 
         timer:tc(
             fun() ->
-                testutil:rotation_withnocheck(
-                    Bookie, Bucket, KeyCount, V1, V2, V3)
+                rotation_withnocheck(
+                    Bookie, Bucket, KeyCount, ObjSize, IdxCount
+                )
             end),
     TC div 1000.
 
+
+rotation_with_prefetch(_Book, _B, 0, _Value, _IdxCnt) ->
+    garbage_collect(),
+    ok;
+rotation_with_prefetch(Book, B, Count, Value, IdxCnt) ->
+    H = erlang:phash2(Count),
+    H1 = H band 127,
+    H2 = (H bsr 7) band 127,
+    H3 = (H bsr 14) band 127,
+    H4 = (H bsr 21) band 63,
+    K = <<H1:8/integer, H2:8/integer, H3:8/integer, H4:8/integer>>,
+    IndexGen = testutil:get_randomindexes_generator(IdxCnt),
+    RemoveSpc =
+        case testutil:book_riakhead(Book, B, K) of
+            not_found ->
+                [];
+            {ok, Head} ->
+                {{SibMetaBin, _Vclock, _Hash, size}, _LMS}
+                    = leveled_head:riak_extract_metadata(Head, size),
+                lists:map(
+                    fun({Fld, Trm}) -> {add, Fld, Trm} end,
+                    leveled_head:get_indexes_from_siblingmetabin(
+                        SibMetaBin, []
+                    )
+                )
+        end,
+    {O, DeltaSpecs} =
+        testutil:set_object(B, K, Value, IndexGen, RemoveSpc),
+    case testutil:book_riakput(Book, O, DeltaSpecs) of
+        ok ->
+            ok;
+        pause ->
+            timer:sleep(?PUT_PAUSE),
+            pause
+    end,
+    rotation_with_prefetch(Book, B, Count - 1, Value, IdxCnt).
+
+
+rotation_withnocheck(Book, B, NumberOfObjects, ObjSize, IdxCnt) ->
+    rotation_with_prefetch(
+        Book,
+        B,
+        NumberOfObjects,
+        base64:encode(leveled_rand:rand_bytes(ObjSize)),
+        IdxCnt
+    ),
+    rotation_with_prefetch(
+        Book,
+        B,
+        NumberOfObjects,
+        base64:encode(leveled_rand:rand_bytes(ObjSize)),
+        IdxCnt
+    ),
+    rotation_with_prefetch(
+        Book,
+        B,
+        NumberOfObjects,
+        base64:encode(leveled_rand:rand_bytes(ObjSize)),
+        IdxCnt
+    ),
+    rotation_with_prefetch(
+        Book,
+        B,
+        NumberOfObjects,
+        base64:encode(leveled_rand:rand_bytes(ObjSize)),
+        IdxCnt
+    ),
+    rotation_with_prefetch(
+        Book,
+        B,
+        NumberOfObjects,
+        base64:encode(leveled_rand:rand_bytes(ObjSize)),
+        IdxCnt
+    ),
+    ok.
+
 generate_chunk(CountPerList, ObjSize, IndexGenFun, Bucket, Chunk) ->
     testutil:generate_objects(
         CountPerList, 
@@ -430,7 +505,7 @@ time_load_chunk(
                 ok ->
                     ThisProcess! {TC, 0};
                 pause ->
-                    timer:sleep(40),
+                    timer:sleep(?PUT_PAUSE),
                     ThisProcess ! {TC + 40000, 1}
             end
         end
@@ -487,34 +562,38 @@ counter(Bookie, estimate) ->
     
 
 random_fetches(FetchType, Bookie, Bucket, ObjCount, Fetches) ->
-    KeysToFetch =
-        lists:map(
-            fun(I) ->
-                Twenty = ObjCount div 5,
-                case I rem 5 of
-                    1 ->
-                        testutil:fixed_bin_key(
-                            Twenty + leveled_rand:uniform(ObjCount - Twenty));
-                    _ ->
-                        testutil:fixed_bin_key(leveled_rand:uniform(Twenty))
-                end
-            end,
-            lists:seq(1, Fetches)
-        ),
+    Twenty = ObjCount div 5,
+    KeyFun = 
+        fun(I) ->        
+            case I rem 5 of
+                1 ->
+                    testutil:fixed_bin_key(
+                        Twenty + leveled_rand:uniform(ObjCount - Twenty));
+                _ ->
+                    testutil:fixed_bin_key(leveled_rand:uniform(Twenty))
+            end
+        end,
     {TC, ok} =
         timer:tc(
             fun() ->
                 lists:foreach(
-                    fun(K) ->
+                    fun(I) ->
+                        K = KeyFun(I),
                         {ok, _} =
                             case FetchType of
+                                riakget ->
+                                    {ok, _} =
+                                        testutil:book_riakhead(
+                                            Bookie, Bucket, K
+                                        ),
+                                    testutil:book_riakget(Bookie, Bucket, K);
                                 get ->
                                     testutil:book_riakget(Bookie, Bucket, K);
                                 head ->
                                     testutil:book_riakhead(Bookie, Bucket, K)
                             end
                     end,
-                    KeysToFetch
+                    lists:seq(1, Fetches)
                 )
             end
         ),
@@ -530,7 +609,7 @@ random_queries(Bookie, Bucket, IDs, IdxCnt, MaxRange, IndexesReturned) ->
         fun() ->
             ID = leveled_rand:uniform(IDs), 
             BinIndex =
-                list_to_binary("binary" ++ integer_to_list(ID) ++ "_bin"),
+                iolist_to_binary(["binary", integer_to_list(ID), "_bin"]),
             Twenty = IdxCnt div 5,
             RI = leveled_rand:uniform(MaxRange),
             [Start, End] =
@@ -615,21 +694,21 @@ profile_fun(
     fun() ->
         random_queries(
             Bookie, Bucket, 10, IndexCount, QuerySize,
-            IndexesReturned div ?MINI_QUERY_DIVISOR)
+            (IndexesReturned * 2) div ?MINI_QUERY_DIVISOR)
     end;
 profile_fun(
         {query, QuerySize},
         {Bookie, Bucket, _KeyCount, _ObjSize, IndexCount, IndexesReturned}) ->
     fun() ->
         random_queries(
-            Bookie, Bucket, 10, IndexCount, QuerySize, IndexesReturned)
+            Bookie, Bucket, 10, IndexCount, QuerySize, IndexesReturned * 2)
     end;
 profile_fun(
         regex_query,
         {Bookie, Bucket, _KeyCount, _ObjSize, _IndexCount, IndexesReturned}) ->
     fun() ->
         random_people_queries(
-            Bookie, Bucket, IndexesReturned div ?RGEX_QUERY_DIVISOR)
+            Bookie, Bucket, (IndexesReturned * 2) div ?RGEX_QUERY_DIVISOR)
     end;
 profile_fun(
         {head, HeadFetches},
@@ -655,7 +734,7 @@ profile_fun(
         update,
         {Bookie, _Bucket, KeyCount, ObjSize, _IndexCount, _IndexesReturned}) ->
     fun() ->
-        rotate_chunk(Bookie, <<"ProfileB">>, KeyCount div 50, ObjSize)
+        rotate_chunk(Bookie, <<"ProfileB">>, KeyCount div 100, ObjSize, 2)
     end;
 profile_fun(
         CounterFold,
@@ -665,7 +744,7 @@ profile_fun(
             full ->
                 20;
             estimate ->
-                40;
+                50;
             guess ->
                 100
         end,

test/end_to_end/testutil.erl

@@ -295,8 +295,11 @@ reset_filestructure(RootPath) when is_list(RootPath) ->
     reset_filestructure(0, RootPath).
 
 reset_filestructure(Wait, RootPath) ->
-    io:format("Waiting ~w ms to give a chance for all file closes " ++
-                 "to complete~n", [Wait]),
+    io:format(
+        "Waiting ~w ms to give a chance for all file closes "
+        "to complete~n",
+        [Wait]
+    ),
     timer:sleep(Wait),
     filelib:ensure_dir(RootPath ++ "/journal/"),
     filelib:ensure_dir(RootPath ++ "/ledger/"),
@@ -311,8 +314,11 @@ wait_for_compaction(Bookie) ->
                             false ->
                                 false;
                             true ->
-                                io:format("Loop ~w waiting for journal "
-                                    ++ "compaction to complete~n", [X]),
+                                io:format(
+                                    "Loop ~w waiting for journal "
+                                    "compaction to complete~n",
+                                    [X]
+                                ),
                                 timer:sleep(5000),
                                 F(Bookie)
                         end end,
@@ -446,11 +452,15 @@ get_compressiblevalue() ->
     Selector = [{1, S1}, {2, S2}, {3, S3}, {4, S4},
                 {5, S5}, {6, S6}, {7, S7}, {8, S8}],
     L = lists:seq(1, 1024),
-    lists:foldl(fun(_X, Acc) ->
-                    {_, Str} = lists:keyfind(leveled_rand:uniform(8), 1, Selector),
-                    Acc ++ Str end,
-                "",
-                L).
+    iolist_to_binary(
+        lists:foldl(
+            fun(_X, Acc) ->
+                {_, Str} = lists:keyfind(leveled_rand:uniform(8), 1, Selector),
+            [Str|Acc] end,
+            [""],
+            L
+        )
+    ).
 
 generate_smallobjects(Count, KeyNumber) ->
     generate_objects(Count, KeyNumber, [], leveled_rand:rand_bytes(512)).
@@ -547,16 +557,22 @@ set_object(Bucket, Key, Value, IndexGen, Indexes2Remove) ->
 set_object(Bucket, Key, Value, IndexGen, Indexes2Remove, IndexesNotToRemove) ->
     IdxSpecs = IndexGen(),
     Indexes =
-        lists:map(fun({add, IdxF, IdxV}) -> {IdxF, IdxV} end,
-                    IdxSpecs ++ IndexesNotToRemove),
+        lists:map(
+            fun({add, IdxF, IdxV}) -> {IdxF, IdxV} end,
+            lists:flatten([IndexesNotToRemove, IdxSpecs])
+        ),
     Obj = {Bucket,
             Key,
             Value,
-            IdxSpecs ++
-                lists:map(fun({add, IdxF, IdxV}) -> {remove, IdxF, IdxV} end,
-                            Indexes2Remove),
-            [{<<"MDK">>, "MDV" ++ Key},
-                {<<"MDK2">>, "MDV" ++ Key},
+            lists:flatten(
+                IdxSpecs,
+                lists:map(
+                    fun({add, IdxF, IdxV}) -> {remove, IdxF, IdxV} end,
+                    Indexes2Remove
+                )
+            ),
+            [{<<"MDK">>, iolist_to_binary([<<"MDV">>, Key])},
+                {<<"MDK2">>, iolist_to_binary([<<"MDV">>, Key])},
                 {?MD_LASTMOD, os:timestamp()},
                 {?MD_INDEX, Indexes}]},
     {B1, K1, V1, DeltaSpecs, MD} = Obj,
@@ -637,8 +653,10 @@ get_value(ObjectBin) ->
             <<SibLength:32/integer, Rest2/binary>> = SibsBin,
             <<ContentBin:SibLength/binary, _MetaBin/binary>> = Rest2,
             case ContentBin of
-                <<0, ContentBin0/binary>> ->
-                    binary_to_term(ContentBin0)
+                <<0:8/integer, ContentBin0/binary>> ->
+                    binary_to_term(ContentBin0);
+                <<1:8/integer, ContentAsIs/binary>> ->
+                    ContentAsIs
             end;
         N ->
             io:format("SibCount of ~w with ObjectBin ~w~n", [N, ObjectBin]),
@@ -696,8 +714,8 @@ get_randomindexes_generator(Count) ->
             lists:map(
                 fun(X) ->
                     {add,
-                        list_to_binary("idx" ++ integer_to_list(X) ++ "_bin"),
-                        list_to_binary(get_randomdate() ++ get_randomname())}
+                        iolist_to_binary(["idx", integer_to_list(X), "_bin"]),
+                        iolist_to_binary([get_randomdate(), get_randomname()])}
                 end,
                 lists:seq(1, Count))
         end,
@@ -845,7 +863,7 @@ put_altered_indexed_objects(Book, Bucket, KSpecL, RemoveOld2i, V) ->
                 end,
             % Note that order in the SpecL is important, as
             % check_indexed_objects, needs to find the latest item added
-            {{K, NewSpecs ++ AddSpc}, AccOut}
+            {{K, lists:append(NewSpecs, AddSpc)}, AccOut}
         end,
     {RplKSpecL, Pauses} = lists:mapfoldl(MapFun, 0, KSpecL),
     io:format(
@@ -939,17 +957,22 @@ compact_and_wait(Book) ->
 compact_and_wait(Book, WaitForDelete) ->
     ok = leveled_bookie:book_compactjournal(Book, 30000),
     F = fun leveled_bookie:book_islastcompactionpending/1,
-    lists:foldl(fun(X, Pending) ->
-                        case Pending of
-                            false ->
-                                false;
-                            true ->
-                                io:format("Loop ~w waiting for journal "
-                                    ++ "compaction to complete~n", [X]),
-                                timer:sleep(20000),
-                                F(Book)
-                        end end,
-                    true,
-                    lists:seq(1, 15)),
+    lists:foldl(
+        fun(X, Pending) ->
+            case Pending of
+                false ->
+                    false;
+                true ->
+                    io:format(
+                        "Loop ~w waiting for journal "
+                        "compaction to complete~n",
+                        [X]
+                    ),
+                    timer:sleep(20000),
+                    F(Book)
+            end
+        end,
+        true,
+        lists:seq(1, 15)),
     io:format("Waiting for journal deletes~n"),
     timer:sleep(WaitForDelete).