umgeher/leveled
0
Fork 0
Code Issues Pull requests Releases Activity Actions

Add lookup support in head_only mode

Browse source 
Originally had disabled the ability to lookup individual values when running in head_only mode.  This is a saving of about 11% at PUT time (about 3 microseconds  per PUT) on a macbook.

Not sure this saving is sufficient enought to justify the extra work if this is used as an AAE Keystore with Bitcask and LWW (when we need to lookup the current value before adjusting).

So reverted to re-adding support for HEAD requests with these keys.
This commit is contained in:
Martin Sumner 2018-02-16 14:16:28 +00:00
parent 2b6281b2b5
commit 910ccb6072
5 changed files with 71 additions and 22 deletions
Download patch file Download diff file Expand all files Collapse all files

11
src/leveled_codec.erl
View file

@ -98,6 +98,9 @@ segment_hash(Key) when is_binary(Key) ->
segment_hash({?RIAK_TAG, Bucket, Key, null})
when is_binary(Bucket), is_binary(Key) ->
segment_hash(<<Bucket/binary, Key/binary>>);
segment_hash({?HEAD_TAG, Bucket, Key, SubKey})
when is_binary(Bucket), is_binary(Key), is_binary(SubKey) ->
segment_hash(<<Bucket/binary, Key/binary, SubKey/binary>>);
segment_hash(Key) ->
segment_hash(term_to_binary(Key)).
@ -229,11 +232,11 @@ from_ledgerkey({_Tag, Bucket, Key, _SubKey}) ->
to_ledgerkey(Bucket, Key, Tag, Field, Value) when Tag == ?IDX_TAG ->
{?IDX_TAG, Bucket, {Field, Value}, Key}.
to_ledgerkey(Bucket, {Key, SubKey}, ?HEAD_TAG) ->
{?HEAD_TAG, Bucket, Key, SubKey};
to_ledgerkey(Bucket, Key, Tag) ->
{Tag, Bucket, Key, null}.
to_ledgerkey(Bucket, Key, Tag, SubKey) ->
{Tag, Bucket, Key, SubKey}.
%% Return the Key, Value and Hash Option for this object. The hash option
%% indicates whether the key would ever be looked up directly, and so if it
@ -481,8 +484,8 @@ gen_headspec(Bucket, Key, IdxOp, SubKey, Value, SQN, TTL) ->
%% TODO: timestamps for delayed reaping
tomb
end,
{to_ledgerkey(Bucket, Key, ?HEAD_TAG, SubKey),
{SQN, Status, no_lookup, Value}}.
K = to_ledgerkey(Bucket, {Key, SubKey}, ?HEAD_TAG),
{K, {SQN, Status, segment_hash(K), Value}}.
-spec aae_indexspecs(false|recent_aae(),