umgeher/leveled
0
Fork 0
Code Issues Pull requests Releases Activity Actions

Remove empty check

Browse source 
It is not obvious why empty binaries can't be merged this way.  BothEmpty seems a pointless expression - and it never gets hit by test coverage.
This commit is contained in:
Martin Sumner 2017-11-01 18:19:37 +00:00
parent 400202e38d
commit 6e0bf7bce3
1 changed files with 1 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

9
src/leveled_tictac.erl
View file

@ -286,14 +286,7 @@ merge_trees(TreeA, TreeB) ->
fun(SQN, MergeL2) ->
L2A = get_level2(TreeA, SQN),
L2B = get_level2(TreeB, SQN),
BothEmpty = (L2A == ?EMPTY) and (L2B == ?EMPTY),
NewLevel2 =
case BothEmpty of
true ->
?EMPTY;
false ->
merge_binaries(L2A, L2B)
end,
NewLevel2 = merge_binaries(L2A, L2B),
array:set(SQN, NewLevel2, MergeL2)
end,
NewLevel2 = lists:foldl(MergeFun,