From 009abdd5998608339aa94a358c0b5142cde49d3d Mon Sep 17 00:00:00 2001 From: Martin Sumner Date: Mon, 24 Feb 2020 09:55:05 +0000 Subject: [PATCH 1/2] Build and test on OTP 22 --- rebar.config | 2 +- src/leveled_inker.erl | 20 ++++++++++++++++++-- src/leveled_penciller.erl | 19 ++++++++++++++++++- 3 files changed, 37 insertions(+), 4 deletions(-) diff --git a/rebar.config b/rebar.config index 40b137f..d20750e 100644 --- a/rebar.config +++ b/rebar.config @@ -1,5 +1,5 @@ {erl_opts, [warnings_as_errors, - {platform_define, "^2[0-1]{1}", fsm_deprecated}, + {platform_define, "^2[0-3]{1}", fsm_deprecated}, {platform_define, "^1[7-8]{1}", old_rand}, {platform_define, "^17", no_log2}, {platform_define, "^R", no_sync}, diff --git a/src/leveled_inker.erl b/src/leveled_inker.erl index 32ee376..9af7fc4 100644 --- a/src/leveled_inker.erl +++ b/src/leveled_inker.erl @@ -1553,9 +1553,25 @@ handle_down_test() -> SnapOpts = #inker_options{start_snapshot=true, bookies_pid = FakeBookie, source_inker=Ink1}, - {ok, Snap1} = ink_snapstart(SnapOpts), + CheckSnapDiesFun = + fun(_X, IsDead) -> + case IsDead of + true -> + true; + false -> + case erlang:process_info(Snap1) of + undefined -> + true; + _ -> + timer:sleep(100), + false + end + end + end, + ?assertNot(lists:foldl(CheckSnapDiesFun, false, [1, 2])), + FakeBookie ! stop, receive @@ -1565,7 +1581,7 @@ handle_down_test() -> ok end, - ?assertEqual(undefined, erlang:process_info(Snap1)), + ?assert(lists:foldl(CheckSnapDiesFun, false, lists:seq(1, 10))), ink_close(Ink1), clean_testdir(RootPath). diff --git a/src/leveled_penciller.erl b/src/leveled_penciller.erl index 4d572bd..7bbf6d4 100644 --- a/src/leveled_penciller.erl +++ b/src/leveled_penciller.erl @@ -2387,6 +2387,23 @@ handle_down_test() -> {FakeBookie, {ok, Snap, null}} -> {ok, Snap, null} end, + + CheckSnapDiesFun = + fun(_X, IsDead) -> + case IsDead of + true -> + true; + false -> + case erlang:process_info(PclSnap) of + undefined -> + true; + _ -> + timer:sleep(100), + false + end + end + end, + ?assertNot(lists:foldl(CheckSnapDiesFun, false, [1, 2])), FakeBookie ! stop, @@ -2397,7 +2414,7 @@ handle_down_test() -> ok end, - ?assertEqual(undefined, erlang:process_info(PclSnap)), + ?assert(lists:foldl(CheckSnapDiesFun, false, lists:seq(1, 10))), pcl_close(PCLr), clean_testdir(RootPath). From 12e84ad628419b95d9303cb2d90f95b577adbfd9 Mon Sep 17 00:00:00 2001 From: Martin Sumner Date: Mon, 24 Feb 2020 12:42:40 +0000 Subject: [PATCH 2/2] Don't add later OTP until we can test it --- rebar.config | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/rebar.config b/rebar.config index d20750e..c651e11 100644 --- a/rebar.config +++ b/rebar.config @@ -1,5 +1,5 @@ {erl_opts, [warnings_as_errors, - {platform_define, "^2[0-3]{1}", fsm_deprecated}, + {platform_define, "^2[0-2]{1}", fsm_deprecated}, {platform_define, "^1[7-8]{1}", old_rand}, {platform_define, "^17", no_log2}, {platform_define, "^R", no_sync},