umgeher/leveled
0
Fork 0
Code Issues Pull requests Releases Activity Actions

Remove integer() support for keys

Browse source 
As number < atom() and so integer() < null.

This causes potential issues where we assume null < then any key value
This commit is contained in:
Martin Sumner 2018-09-03 10:50:28 +01:00
parent f400e8b46d
commit 402dd2a663
1 changed files with 4 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

8
src/leveled_bookie.erl
View file

@ -162,7 +162,7 @@
-type head_timings() :: no_timing|#head_timings{}. -type head_timings() :: no_timing|#head_timings{}.
-type timing_types() :: head|get|put|fold. -type timing_types() :: head|get|put|fold.
-type recent_aae() :: false|#recent_aae{}|undefined. -type recent_aae() :: false|#recent_aae{}|undefined.
-type key() :: binary()|integer()|string(). -type key() :: binary()|string().
-type open_options() :: -type open_options() ::
%% For full description of options see ../docs/STARTUP_OPTIONS.md %% For full description of options see ../docs/STARTUP_OPTIONS.md
[{root_path, string()|undefined} | [{root_path, string()|undefined} |
@ -2175,8 +2175,8 @@ is_empty_headonly_test() ->
{head_only, no_lookup}]), {head_only, no_lookup}]),
?assertMatch(true, book_isempty(Bookie1, ?HEAD_TAG)), ?assertMatch(true, book_isempty(Bookie1, ?HEAD_TAG)),
ObjSpecs = ObjSpecs =
[{add, <<"B1">>, <<"K1">>, 1, 100}, [{add, <<"B1">>, <<"K1">>, <<1:8/integer>>, 100},
{remove, <<"B1">>, <<"K1">>, 0, null}], {remove, <<"B1">>, <<"K1">>, <<0:8/integer>>, null}],
ok = book_mput(Bookie1, ObjSpecs), ok = book_mput(Bookie1, ObjSpecs),
?assertMatch(false, book_isempty(Bookie1, ?HEAD_TAG)), ?assertMatch(false, book_isempty(Bookie1, ?HEAD_TAG)),
ok = book_close(Bookie1). ok = book_close(Bookie1).
@ -2197,7 +2197,7 @@ foldkeys_headonly_tester(ObjectCount, BlockSize, BStr) ->
GenObjSpecFun = GenObjSpecFun =
fun(I) -> fun(I) ->
Key = I rem 6, Key = I rem 6,
{add, BStr, <<Key:8/integer>>, I, erlang:phash2(I)} {add, BStr, <<Key:8/integer>>, integer_to_list(I), I}
end, end,
ObjSpecs = lists:map(GenObjSpecFun, lists:seq(1, ObjectCount)), ObjSpecs = lists:map(GenObjSpecFun, lists:seq(1, ObjectCount)),
ObjSpecBlocks = ObjSpecBlocks =