From c2b7863a53549029d8841da5c35fd3bdbf767417 Mon Sep 17 00:00:00 2001 From: Michael Klishin Date: Tue, 15 Dec 2020 01:45:43 +0300 Subject: [PATCH 1/2] Avoid a warning on Erlang/OTP 24 to make sure Rebar 3 can bootstrap on that version with warnings-as-errors compiler settings. Closes #145. --- src/ec_cmd_log.erl | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/ec_cmd_log.erl b/src/ec_cmd_log.erl index b61bbd0..4151216 100644 --- a/src/ec_cmd_log.erl +++ b/src/ec_cmd_log.erl @@ -22,6 +22,9 @@ %%% use this to talk to the users if you are wrting code for the system -module(ec_cmd_log). +%% Avoids a warning on Erlang/OTP 24 +-compile({no_auto_import,[error/3]}). + -export([new/1, new/2, new/3, From 8eef97234fc69ec59b1c086ce13cab6564fa7c8e Mon Sep 17 00:00:00 2001 From: Michael Klishin Date: Wed, 16 Dec 2020 00:10:38 +0300 Subject: [PATCH 2/2] Better comment wording as suggested by @ferd Co-authored-by: Fred Hebert --- src/ec_cmd_log.erl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/ec_cmd_log.erl b/src/ec_cmd_log.erl index 4151216..c601782 100644 --- a/src/ec_cmd_log.erl +++ b/src/ec_cmd_log.erl @@ -22,7 +22,7 @@ %%% use this to talk to the users if you are wrting code for the system -module(ec_cmd_log). -%% Avoids a warning on Erlang/OTP 24 +%% Avoid clashing with `error/3` BIF added in Erlang/OTP 24 -compile({no_auto_import,[error/3]}). -export([new/1,