0
Fork 0
mirror of https://github.com/ninenines/cowboy.git synced 2025-07-14 20:30:23 +00:00
Commit graph

1967 commits

Author SHA1 Message Date
Loïc Hoguin
ccf7a242b4 Ensure the listening socket gets closed with the listener supervisor.
Moved the Transport:listen call to cowboy_acceptors_sup. This make it
depend on a child of cowboy_listener_sup instead of cowboy_sup, which
isn't getting shut down when calling cowboy:stop_listener/1 and thus
didn't close the listening socket.
2011-04-03 01:44:52 +02:00
Loïc Hoguin
718baffa3c Make Cowboy an OTP application again, properly this time.
As requested by many people on IRC Cowboy is now a proper OTP application
to support soft code upgrades. It should also be easier to start and stop
listeners now using cowboy:start_listener/6 and cowboy:stop_listener/1.
2011-04-03 00:21:47 +02:00
Loïc Hoguin
e4da6956fc Anonymize and improve the cowboy supervision tree.
* Cowboy isn't an OTP application anymore; just a supervisor.
* All processes started by Cowboy are now anonymous.
* All processes related to a listener are now part of its supervision tree.
2011-04-02 20:27:16 +02:00
Loïc Hoguin
e6e5b1767f Merge remote-tracking branch 'nox/improve-http-req' 2011-03-29 14:48:40 +02:00
Anthony Ramine
101034842e Make the default value the last parameter of HTTP req accessors
This makes cowboy_http_req's qs_val/3, binding/3 and header/3 behave like
proplists:get_value/3.
2011-03-29 14:20:51 +02:00
Anthony Ramine
96a770620e Make HTTP req accessors call themselves with their default default value
Use lists:keyfind/3 in qs_val/3, binding/3 and header/3 and make qs_val/2,
binding/2 and header/2 call those.
2011-03-29 14:18:31 +02:00
Anthony Ramine
4eeabe5612 Fix cowboy_http_req:body with regard to the new accessors default value
header/2 now returns 'undefined' when the header isn't in the request.
2011-03-29 13:58:03 +02:00
Loïc Hoguin
150723ca21 Return undefined instead of failing or returning "" when a value doesn't exist. 2011-03-27 13:11:57 +02:00
Loïc Hoguin
d0d9b0e8b3 Use a more efficient variant of string:to_lower to improve performance.
After much testing and experimentation of all kinds I find lists to be both
faster and using less memory than binaries for request-line and headers
handling. This is more than likely due to the fact that headers are very
short and thus do not benefit from the advantages of refc binaries, meaning
they're copied, just like lists. The memory usage discrepancy is still a
mystery for the most part, although the hoops needed to perform operations
on the binaries are probably responsible for the extra memory use.

I'm thus giving up on trying to use binaries for request-line and headers.
Instead, this commit improves performances even more to the lists code,
making lists 5% faster than binaries. Lists are easier to work with too,
so I guess it's all a big win for everyone.

Of course the request body is still read as a binary, we're using the
binary type where it performs best.
2011-03-27 01:16:11 +01:00
Loïc Hoguin
5726aa3d85 Match early in connection_to_atom for a small performance improvement. 2011-03-27 01:11:33 +01:00
Loïc Hoguin
71e940a6eb Fix query string related type specs in cowboy_http_req. 2011-03-27 01:09:47 +01:00
Loïc Hoguin
c285f00349 Fix the type spec for qs_vals, a list of key/values. 2011-03-27 01:07:01 +01:00
Loïc Hoguin
e69597f29e Add the cowboy_http_handler behaviour. 2011-03-24 13:48:52 +01:00
Loïc Hoguin
e5bce3ca88 Merge remote-tracking branch 'ndim/master' 2011-03-23 13:56:17 +01:00
Hans Ulrich Niedermann
07413113d5 Makefile: Use a REBAR variable
Using a REBAR variable makes it easy for the user to override
the REBAR to be called.
2011-03-23 10:54:09 +01:00
Loïc Hoguin
9fe8141d2a Allow Handler:init/3 to request a protocol upgrade. 2011-03-22 23:03:43 +01:00
Loïc Hoguin
7888be00d2 Forward transport and protocol name to Handler:init. 2011-03-22 19:50:02 +01:00
Loïc Hoguin
e0185dd27f Add cowboy_tcp_transport:name/0 to ease transport identification later on. 2011-03-22 19:40:28 +01:00
Loïc Hoguin
3865415a60 Boring 80-col change. 2011-03-22 13:23:40 +01:00
Loïc Hoguin
06274cd8ab Introduce cowboy_http_req:body_qs/1 for automated urlencoded body parsing. 2011-03-22 13:20:21 +01:00
Loïc Hoguin
775a03e6eb Fix spec for cowboy_http_req:parse_qs/1. 2011-03-22 13:19:38 +01:00
Loïc Hoguin
c645b682e7 Fix spec for cowboy_http_req:body/1 and body/2. 2011-03-22 13:18:53 +01:00
Loïc Hoguin
c3a36246b5 Explicitly ignore the return value of cowboy_http_req:reply in error_response. 2011-03-22 12:27:34 +01:00
Loïc Hoguin
d4c071c2d0 Fix the type spec for path_tokens, a list of *non empty* strings. 2011-03-22 12:26:07 +01:00
Loïc Hoguin
06ff8607ed Add more dialyzer warnings to rebar.config. 2011-03-22 12:25:43 +01:00
Loïc Hoguin
3b6f3004a6 Add a rebar.config file with useful options. 2011-03-21 23:36:51 +01:00
Loïc Hoguin
1ebfa5eb1f Fix spec for cowboy_tcp_transport:close/1.
Apparently the documentation is wrong for gen_tcp:close/1, it returns only ok.
2011-03-21 22:57:07 +01:00
Loïc Hoguin
545116edfa Fix spec for cowboy_http_req:reply/4. 2011-03-21 22:47:37 +01:00
Loïc Hoguin
fdd9d4c0ef Fix spec for cowboy_http_req:qs_vals/1. 2011-03-21 22:33:42 +01:00
Loïc Hoguin
0c0b75f76b Fix spec for the #http_spec.path record field. 2011-03-21 22:32:02 +01:00
Loïc Hoguin
c366343ac6 Fix spec for cowboy_http_protocol:init/3. 2011-03-21 22:22:30 +01:00
Loïc Hoguin
0b13835bfe Fix tests for cowboy_dispatcher:split_path/1. 2011-03-21 22:18:24 +01:00
Loïc Hoguin
8e55c2e2b8 Fix spec for cowboy_dispatcher:split_path/1. 2011-03-21 22:13:35 +01:00
Loïc Hoguin
193968d53e Fix spec for cowboy_dispatcher:split_host/1. 2011-03-21 22:13:27 +01:00
Loïc Hoguin
7cacb88fec Introduce cowboy_http_req:body/1 to read the full request body. 2011-03-21 22:08:27 +01:00
Loïc Hoguin
e9781e77f1 Make sure error_response always returns ok. 2011-03-21 17:52:27 +01:00
Loïc Hoguin
e3dc9b2694 Add specs to ensure_response and change the clauses order. 2011-03-21 17:51:21 +01:00
Loïc Hoguin
8b02992e6a Skip the request body if it hasn't been read by the handler. 2011-03-21 17:47:17 +01:00
Loïc Hoguin
e40001a884 Ensure a response is sent when the handler doesn't reply anything. 2011-03-20 19:38:45 +01:00
Loïc Hoguin
a1e56a2fba Move the error response code into a separate function. 2011-03-20 19:29:32 +01:00
Loïc Hoguin
71b31cee92 Make sure we can only reply to an HTTP request inside Handler:handle.
Of course since requests are a record the response state can be explicitly
overriden, but standard use prevents errors by making sure only one reply
is sent.
2011-03-20 18:03:36 +01:00
Loïc Hoguin
d69d0adfa7 Lazy-retrieve the peer name and port to avoid wasting time each request. 2011-03-20 16:09:05 +01:00
Loïc Hoguin
f5e7178651 Change a @todo for Handler:init possible return values. 2011-03-20 15:30:29 +01:00
Loïc Hoguin
a3fff2f5b0 Rename a variable in cowboy_http_protocol for clarity. 2011-03-20 15:10:58 +01:00
Loïc Hoguin
df35916d2a Allow code reloading inside the cowboy_http_protocol module during keep-alive. 2011-03-20 14:24:43 +01:00
Loïc Hoguin
c4d4b6a051 Rename the title for Getting Started in the README. 2011-03-20 14:15:58 +01:00
Loïc Hoguin
6fad3f7824 Default the connection to keep-alive on HTTP/1.1 and close on 1.0. 2011-03-20 00:09:15 +01:00
Loïc Hoguin
896b854908 Remove a dead code clause for split_path. 2011-03-20 00:03:02 +01:00
Loïc Hoguin
b874b28561 Save the raw path string in the request. 2011-03-20 00:01:29 +01:00
Loïc Hoguin
8085529f48 Save the raw host string in the request. 2011-03-19 23:57:23 +01:00