umgeher/cowboy
0
Fork 0
mirror of https://github.com/ninenines/cowboy.git synced 2025-07-14 12:20:24 +00:00
Code Issues Wiki Activity

Fix HTTP/1.1 pipelining

Browse source 
Cases where a request body was involved could sometimes
fail depending on timing. Also fix all of the old
http_SUITE tests.
This commit is contained in:
Loïc Hoguin 2017-12-12 11:37:48 +01:00
parent 01e13c0846
commit eafca21198
No known key found for this signature in database
GPG key ID: 8A9DF795F6FED764
3 changed files with 20 additions and 10 deletions
Download patch file Download diff file Expand all files Collapse all files

14
test/http_SUITE.erl
View file

@ -464,9 +464,15 @@ rest_keepalive(Config) ->
rest_keepalive_post(Config) ->
ConnPid = gun_open(Config),
Refs = [begin
Ref1 = gun:post(ConnPid, "/forbidden_post", [{<<"content-type">>, <<"text/plain">>}]),
Ref1 = gun:post(ConnPid, "/forbidden_post", [
{<<"content-type">>, <<"text/plain">>},
{<<"content-length">>, <<"12">>}
]),
gun:data(ConnPid, Ref1, fin, "Hello world!"),
Ref2 = gun:post(ConnPid, "/simple_post", [{<<"content-type">>, <<"text/plain">>}]),
Ref2 = gun:post(ConnPid, "/simple_post", [
{<<"content-type">>, <<"text/plain">>},
{<<"content-length">>, <<"12">>}
]),
gun:data(ConnPid, Ref2, fin, "Hello world!"),
{Ref1, Ref2}
end || _ <- lists:seq(1, 5)],
@ -550,8 +556,8 @@ rest_resource_etags(Config) ->
{200, <<"\"etag-header-value\"">>, "tuple-strong"},
{200, <<"W/\"etag-header-value\"">>, "binary-weak-quoted"},
{200, <<"\"etag-header-value\"">>, "binary-strong-quoted"},
{400, false, "binary-strong-unquoted"},
{400, false, "binary-weak-unquoted"}
{500, false, "binary-strong-unquoted"},
{500, false, "binary-weak-unquoted"}
],
_ = [{Status, ETag, Type} = begin
{Ret, RespETag} = rest_resource_get_etag(Config, Type),