umgeher/cowboy
0
Fork 0
mirror of https://github.com/ninenines/cowboy.git synced 2025-07-14 04:10:24 +00:00
Code Issues Wiki Activity

Document body reading in auto mode

Browse source 
It is now tested both via cowboy_req:read_body and
via cowboy_req:cast.

Removes a bad example from the guide of body reading
with period of infinity, which does not work.
This commit is contained in:
Loïc Hoguin 2024-01-08 15:13:18 +01:00
parent c1490d7d55
commit e4a78aaeb1
No known key found for this signature in database
GPG key ID: 8A9DF795F6FED764
8 changed files with 137 additions and 21 deletions
Download patch file Download diff file Expand all files Collapse all files

21
test/handlers/echo_h.erl
View file

@ -25,6 +25,8 @@ echo(<<"read_body">>, Req0, Opts) ->
timer:sleep(500),
cowboy_req:read_body(Req0);
<<"/full", _/bits>> -> read_body(Req0, <<>>);
<<"/auto-sync", _/bits>> -> read_body_auto_sync(Req0, <<>>);
<<"/auto-async", _/bits>> -> read_body_auto_async(Req0, <<>>);
<<"/length", _/bits>> ->
{_, _, Req1} = read_body(Req0, <<>>),
Length = cowboy_req:body_length(Req1),
@ -122,6 +124,25 @@ read_body(Req0, Acc) ->
{more, Data, Req} -> read_body(Req, << Acc/binary, Data/binary >>)
end.
read_body_auto_sync(Req0, Acc) ->
Opts = #{length => auto, period => infinity},
case cowboy_req:read_body(Req0, Opts) of
{ok, Data, Req} -> {ok, << Acc/binary, Data/binary >>, Req};
{more, Data, Req} -> read_body_auto_sync(Req, << Acc/binary, Data/binary >>)
end.
read_body_auto_async(Req, Acc) ->
read_body_auto_async(Req, make_ref(), Acc).
read_body_auto_async(Req, ReadBodyRef, Acc) ->
cowboy_req:cast({read_body, self(), ReadBodyRef, auto, infinity}, Req),
receive
{request_body, ReadBodyRef, nofin, Data} ->
read_body_auto_async(Req, ReadBodyRef, <<Acc/binary, Data/binary>>);
{request_body, ReadBodyRef, fin, _, Data} ->
{ok, <<Acc/binary, Data/binary>>, Req}
end.
value_to_iodata(V) when is_integer(V) -> integer_to_binary(V);
value_to_iodata(V) when is_atom(V) -> atom_to_binary(V, latin1);
value_to_iodata(V) when is_list(V); is_tuple(V); is_map(V) -> io_lib:format("~999999p", [V]);

8
test/req_SUITE.erl
View file

@ -64,6 +64,8 @@ init_dispatch(Config) ->
{"/opts/:key/timeout", echo_h, #{timeout => 1000, crash => true}},
{"/100-continue/:key", echo_h, []},
{"/full/:key", echo_h, []},
{"/auto-sync/:key", echo_h, []},
{"/auto-async/:key", echo_h, []},
{"/spawn/:key", echo_h, []},
{"/no/:key", echo_h, []},
{"/direct/:key/[...]", echo_h, []},
@ -524,6 +526,12 @@ do_read_body_timeout(Path, Body, Config) ->
{response, _, 500, _} = gun:await(ConnPid, Ref, infinity),
gun:close(ConnPid).
read_body_auto(Config) ->
doc("Read the request body using auto mode."),
<<0:80000000>> = do_body("POST", "/auto-sync/read_body", [], <<0:80000000>>, Config),
<<0:80000000>> = do_body("POST", "/auto-async/read_body", [], <<0:80000000>>, Config),
ok.
read_body_spawn(Config) ->
doc("Confirm we can use cowboy_req:read_body/1,2 from another process."),
<<"hello world!">> = do_body("POST", "/spawn/read_body", [], "hello world!", Config),