umgeher/cowboy
0
Fork 0
mirror of https://github.com/ninenines/cowboy.git synced 2025-07-14 20:30:23 +00:00
Code Issues Wiki Activity

Avoid a duplicate HTTP reply in cowboy_websocket:upgrade_error/1

Browse source 
Do this by checking whether we received the resp_sent message.
This commit is contained in:
Loïc Hoguin 2012-09-15 21:18:53 +02:00
parent 35ebe0b108
commit cd54214def
1 changed files with 6 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

9
src/cowboy_websocket.erl
View file

@ -140,9 +140,12 @@ handler_init(State=#state{transport=Transport, handler=Handler, opts=Opts},
-spec upgrade_error(cowboy_req:req()) -> closed.
upgrade_error(Req) ->
{ok, _Req2} = cowboy_req:reply(400, [], [],
Req#http_req{resp_state=waiting}),
closed.
receive
{cowboy_req, resp_sent} -> closed
after 0 ->
_ = cowboy_req:reply(400, [], [], Req),
closed
end.
%% @see cowboy_protocol:ensure_response/1
-spec upgrade_denied(cowboy_req:req()) -> closed.