umgeher/cowboy
0
Fork 0
mirror of https://github.com/ninenines/cowboy.git synced 2025-07-14 12:20:24 +00:00
Code Issues Wiki Activity

Add more rfc7230 tests and better handle bad chunk sizes

Browse source 
Bad chunk sizes used to be accepted and could result in
a badly parsed body or a timeout. They are now properly
rejected.

Chunk extensions now have a hard limit of 129 characters.
I haven't heard of anyone using them and Cowboy does not
provide an interface for them, but we can always increase
or make configurable if it ever becomes necessary (but
I honestly doubt it).

Also a test from the old http suite could be removed. Yay!
This commit is contained in:
Loïc Hoguin 2017-11-22 15:39:39 +01:00
parent 1af508c4cd
commit c4e43ec26a
No known key found for this signature in database
GPG key ID: 8A9DF795F6FED764
4 changed files with 296 additions and 109 deletions
Download patch file Download diff file Expand all files Collapse all files

13
test/http_SUITE.erl
View file

@ -307,19 +307,6 @@ http10_keepalive_forced(Config) ->
_ -> ok
end.
keepalive_max(Config) ->
ConnPid = gun_open(Config),
Refs = [gun:get(ConnPid, "/", [{<<"connection">>, <<"keep-alive">>}])
|| _ <- lists:seq(1, 99)],
CloseRef = gun:get(ConnPid, "/", [{<<"connection">>, <<"keep-alive">>}]),
_ = [begin
{response, nofin, 200, Headers} = gun:await(ConnPid, Ref),
false = lists:keymember(<<"connection">>, 1, Headers)
end || Ref <- Refs],
{response, nofin, 200, Headers} = gun:await(ConnPid, CloseRef),
{_, <<"close">>} = lists:keyfind(<<"connection">>, 1, Headers),
gun_down(ConnPid).
keepalive_nl(Config) ->
ConnPid = gun_open(Config),
Refs = [begin