umgeher/cowboy
0
Fork 0
mirror of https://github.com/ninenines/cowboy.git synced 2025-07-14 12:20:24 +00:00
Code Issues Wiki Activity

Remove the 'HEAD' chunked_reply/3 clause

Browse source 
From the RFC:
  The HEAD method is identical to GET except that the server MUST NOT
  return a message-body in the response. The metainformation contained
  in the HTTP headers in response to a HEAD request SHOULD be identical
  to the information sent in response to a GET request.
This commit is contained in:
Loïc Hoguin 2011-10-05 17:55:25 +02:00
parent 8eb7af0a0b
commit c2be0f2073
2 changed files with 2 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

2
src/cowboy_http_protocol.erl
View file

@ -284,6 +284,8 @@ ensure_response(Req=#http_req{resp_state=waiting}) ->
_ = cowboy_http_req:reply(204, [], [], Req),
ok;
%% Close the chunked reply.
ensure_response(#http_req{method='HEAD', resp_state=chunks}) ->
close;
ensure_response(#http_req{socket=Socket, transport=Transport,
resp_state=chunks}) ->
Transport:send(Socket, <<"0\r\n\r\n">>),

8
src/cowboy_http_req.erl
View file

@ -335,14 +335,6 @@ reply(Code, Headers, Body, Req=#http_req{socket=Socket,
%% @see cowboy_http_req:chunk/2
-spec chunked_reply(http_status(), http_headers(), #http_req{})
-> {ok, #http_req{}}.
chunked_reply(Code, Headers, Req=#http_req{socket=Socket, transport=Transport,
method='HEAD', resp_state=waiting}) ->
Head = response_head(Code, Headers, [
{<<"Date">>, cowboy_clock:rfc1123()},
{<<"Server">>, <<"Cowboy">>}
]),
Transport:send(Socket, Head),
{ok, Req#http_req{resp_state=done}};
chunked_reply(Code, Headers, Req=#http_req{socket=Socket, transport=Transport,
resp_state=waiting}) ->
Head = response_head(Code, Headers, [