umgeher/cowboy
0
Fork 0
mirror of https://github.com/ninenines/cowboy.git synced 2025-07-14 12:20:24 +00:00
Code Issues Wiki Activity

Properly handle OPTIONS * requests

Browse source 
Support for these was broken during the development
of Cowboy 2.0. It is now fixed and better handled
than it ever was.
This commit is contained in:
Loïc Hoguin 2017-12-06 14:05:30 +01:00
parent 2eb3e3f994
commit bc39b433bb
No known key found for this signature in database
GPG key ID: 8A9DF795F6FED764
5 changed files with 38 additions and 19 deletions
Download patch file Download diff file Expand all files Collapse all files

24
test/rfc7231_SUITE.erl
View file

@ -34,6 +34,7 @@ end_per_group(Name, _) ->
init_dispatch(_) ->
cowboy_router:compile([{"[...]", [
{"*", asterisk_h, []},
{"/", hello_h, []},
{"/echo/:key", echo_h, []},
{"/resp/:key[/:arg]", resp_h, []}
@ -148,8 +149,27 @@ method_options(Config) ->
{ok, <<"OPTIONS">>} = gun:await_body(ConnPid, Ref),
ok.
%method_options_asterisk(Config) ->
%method_options_content_length_0(Config) ->
method_options_asterisk(Config) ->
doc("The OPTIONS method is accepted with an asterisk. (RFC7231 4.3.7)"),
ConnPid = gun_open(Config),
Ref = gun:options(ConnPid, "*", [
{<<"accept-encoding">>, <<"gzip">>},
{<<"x-echo">>, <<"method">>}
]),
{response, nofin, 200, _} = gun:await(ConnPid, Ref),
{ok, <<"OPTIONS">>} = gun:await_body(ConnPid, Ref),
ok.
method_options_content_length_0(Config) ->
doc("The OPTIONS method must set the content-length header "
"to 0 when no body is returned. (RFC7231 4.3.7)"),
ConnPid = gun_open(Config),
Ref = gun:options(ConnPid, "*", [
{<<"accept-encoding">>, <<"gzip">>}
]),
{response, fin, 200, Headers} = gun:await(ConnPid, Ref),
{_, <<"0">>} = lists:keyfind(<<"content-length">>, 1, Headers),
ok.
method_trace(Config) ->
doc("The TRACE method is currently not implemented. (RFC7231 4.3.8)"),