umgeher/cowboy
0
Fork 0
mirror of https://github.com/ninenines/cowboy.git synced 2025-07-14 12:20:24 +00:00
Code Issues Wiki Activity

Don't include a content-length in 204 responses

Browse source
This commit is contained in:
Loïc Hoguin 2017-11-29 21:38:10 +01:00
parent 8d9404e9b6
commit b0519af42a
No known key found for this signature in database
GPG key ID: 8A9DF795F6FED764
2 changed files with 6 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

5
src/cowboy_req.erl
View file

@ -725,6 +725,11 @@ reply(Status, Headers, SendFile = {sendfile, _, Len, _}, Req)
do_reply(Status, Headers#{ do_reply(Status, Headers#{
<<"content-length">> => integer_to_binary(Len) <<"content-length">> => integer_to_binary(Len)
}, SendFile, Req); }, SendFile, Req);
%% 204 responses must not include content-length. (RFC7230 3.3.1, RFC7230 3.3.2)
reply(Status=204, Headers, Body, Req) ->
do_reply(Status, Headers, Body, Req);
reply(Status= <<"204",_/bits>>, Headers, Body, Req) ->
do_reply(Status, Headers, Body, Req);
reply(Status, Headers, Body, Req) reply(Status, Headers, Body, Req)
when is_integer(Status); is_binary(Status) -> when is_integer(Status); is_binary(Status) ->
do_reply(Status, Headers#{ do_reply(Status, Headers#{

2
test/rfc7230_SUITE.erl
View file

@ -1764,7 +1764,7 @@ no_content_length_in_204_response(Config) ->
"(RFC7230 3.3.1, RFC7230 3.3.2)"), "(RFC7230 3.3.1, RFC7230 3.3.2)"),
Client = raw_open(Config), Client = raw_open(Config),
ok = raw_send(Client, [ ok = raw_send(Client, [
"GET /resp/reply4/204 HTTP/1.1\r\n" "GET /resp/reply3/204 HTTP/1.1\r\n"
"Host: localhost\r\n" "Host: localhost\r\n"
"\r\n"]), "\r\n"]),
{_, 204, _, Rest} = cow_http:parse_status_line(raw_recv_head(Client)), {_, 204, _, Rest} = cow_http:parse_status_line(raw_recv_head(Client)),