Always dialyze tests and fix some cowboy_req specs

test/handlers/resp_h.erl

@@ -2,6 +2,10 @@
 
 -module(resp_h).
 
+%% @todo Probably should have a separate handler for errors,
+%% so that we can dialyze all the other correct calls.
+-dialyzer({nowarn_function, do/3}).
+
 -export([init/2]).
 
 init(Req, Opts) ->

test/handlers/resp_iolist_body_h.erl

@@ -2,6 +2,8 @@
 
 -module(resp_iolist_body_h).
 
+-dialyzer(no_improper_lists).
+
 -export([init/2]).
 
 init(Req0, State) ->

test/handlers/stream_handler_h.erl

@@ -107,6 +107,7 @@ early_error(StreamID, Reason, PartialReq, Resp, Opts) ->
 	end.
 
 %% @todo It would be good if we could allow this function to return normally.
+-spec takeover(_, _, _, _, _, _, _) -> no_return().
 takeover(Parent, Ref, Socket, Transport, Opts, Buffer, State=#state{pid=Pid}) ->
 	Pid ! {Pid, self(), takeover, Parent, Ref, Socket, Transport, Opts, Buffer, State},
 	exit(normal).

test/handlers/switch_protocol_flush_h.erl

@@ -27,6 +27,8 @@ info(_, _, State) ->
 terminate(_, _, _) ->
 	ok.
 
+%% @todo It would be good if we could allow this function to return normally.
+-spec takeover(_, _, _, _, _, _, _) -> no_return().
 takeover(_, _, _, _, _, _, Pid) ->
 	Msgs = receive_all([]),
 	Pid ! {Pid, Msgs},

test/handlers/ws_terminate_h.erl

@@ -31,4 +31,5 @@ websocket_info(_, State) ->
 	{ok, State}.
 
 terminate(Reason, Req, #state{pid=Pid}) ->
-	Pid ! {terminate, Reason, Req}.
+	Pid ! {terminate, Reason, Req},
+	ok.