umgeher/cowboy
0
Fork 0
mirror of https://github.com/ninenines/cowboy.git synced 2025-07-16 05:00:24 +00:00
Code Issues Wiki Activity

Change the order of set_resp_cookie arguments

Browse source 
The Opts value is put last, to be more consistent with the
rest of the cowboy_req module.

Additionally a test handler was fixed which reduced the number
of errors in http_SUITE.
This commit is contained in:
Loïc Hoguin 2017-02-19 09:46:11 +01:00
parent 87a05a1219
commit 91ae70b06c
No known key found for this signature in database
GPG key ID: 71366FF21851DF03
6 changed files with 34 additions and 42 deletions
Download patch file Download diff file Expand all files Collapse all files

6
src/cowboy_req.erl
View file

@ -548,7 +548,7 @@ stream_multipart(Req=#{multipart := {Boundary, Buffer}}, _) ->
-spec set_resp_cookie(iodata(), iodata(), Req)
-> Req when Req::req().
set_resp_cookie(Name, Value, Req) ->
set_resp_cookie(Name, Value, #{}, Req).
set_resp_cookie(Name, Value, Req, #{}).
%% The cookie name cannot contain any of the following characters:
%% =,;\s\t\r\n\013\014
@ -556,9 +556,9 @@ set_resp_cookie(Name, Value, Req) ->
%% The cookie value cannot contain any of the following characters:
%% ,; \t\r\n\013\014
%% @todo Fix the cookie_opts() type.
-spec set_resp_cookie(binary(), iodata(), cookie_opts(), Req)
-spec set_resp_cookie(binary(), iodata(), Req, cookie_opts())
-> Req when Req::req().
set_resp_cookie(Name, Value, Opts, Req) ->
set_resp_cookie(Name, Value, Req, Opts) ->
Cookie = cow_cookie:setcookie(Name, Value, maps:to_list(Opts)),
RespCookies = maps:get(resp_cookies, Req, #{}),
Req#{resp_cookies => RespCookies#{Name => Cookie}}.