0
Fork 0
mirror of https://github.com/ninenines/cowboy.git synced 2025-07-14 20:30:23 +00:00

Change the returned value for language_range parsing

Considering how it must be used, a simple binary is much better
than a tag and a list of subtags. We still parse them like this
to make sure they follow the specs, though.
This commit is contained in:
Loïc Hoguin 2011-12-01 20:38:38 +01:00
parent 2ae5e804fb
commit 83ec63374f

View file

@ -236,7 +236,7 @@ language_tag(Data, Fun) ->
(<< $-, Rest/bits >>, Tag) ->
language_subtag(Rest, Fun, Tag, []);
(Rest, Tag) ->
Fun(Rest, {Tag, []})
Fun(Rest, Tag)
end).
-spec language_subtag(binary(), fun(), binary(), [binary()]) -> any().
@ -247,7 +247,9 @@ language_subtag(Data, Fun, Tag, Acc) ->
(<< $-, Rest/bits >>, SubTag) ->
language_subtag(Rest, Fun, Tag, [SubTag|Acc]);
(Rest, SubTag) ->
Fun(Rest, {Tag, lists:reverse([SubTag|Acc])})
%% Rebuild the full tag now that we know it's correct
Sub = << << $-, S/binary >> || S <- lists:reverse([SubTag|Acc]) >>,
Fun(Rest, << Tag/binary, Sub/binary >>)
end).
-spec maybe_qparam(binary(), fun()) -> any().
@ -687,16 +689,16 @@ nonempty_language_range_list_test_() ->
%% {Value, Result}
Tests = [
{<<"da, en-gb;q=0.8, en;q=0.7">>, [
{{<<"da">>, []}, 1000},
{{<<"en">>, [<<"gb">>]}, 800},
{{<<"en">>, []}, 700}
{<<"da">>, 1000},
{<<"en-gb">>, 800},
{<<"en">>, 700}
]},
{<<"en, en-US, en-cockney, i-cherokee, x-pig-latin">>, [
{{<<"en">>, []}, 1000},
{{<<"en">>, [<<"us">>]}, 1000},
{{<<"en">>, [<<"cockney">>]}, 1000},
{{<<"i">>, [<<"cherokee">>]}, 1000},
{{<<"x">>, [<<"pig">>, <<"latin">>]}, 1000}
{<<"en">>, 1000},
{<<"en-us">>, 1000},
{<<"en-cockney">>, 1000},
{<<"i-cherokee">>, 1000},
{<<"x-pig-latin">>, 1000}
]}
],
[{V, fun() -> R = nonempty_list(V, fun language_range/2) end}