umgeher/cowboy
0
Fork 0
mirror of https://github.com/ninenines/cowboy.git synced 2025-07-14 12:20:24 +00:00
Code Issues Wiki Activity

Make cowboy_req:has_body/1 return boolean()

Browse source 
This makes it similar to the other has_* functions.
This commit is contained in:
Loïc Hoguin 2013-01-19 17:20:35 +01:00
parent 645556a80a
commit 82de4254dd
3 changed files with 8 additions and 9 deletions
Download patch file Download diff file Expand all files Collapse all files

6
examples/echo_post/src/toppage_handler.erl
View file

@ -12,9 +12,9 @@ init(_Transport, Req, []) ->
handle(Req, State) -> handle(Req, State) ->
{Method, Req2} = cowboy_req:method(Req), {Method, Req2} = cowboy_req:method(Req),
{HasBody, Req3} = cowboy_req:has_body(Req2), HasBody = cowboy_req:has_body(Req2),
{ok, Req4} = maybe_echo(Method, HasBody, Req3), {ok, Req3} = maybe_echo(Method, HasBody, Req2),
{ok, Req4, State}. {ok, Req3, State}.
maybe_echo(<<"POST">>, true, Req) -> maybe_echo(<<"POST">>, true, Req) ->
{ok, PostVals, Req2} = cowboy_req:body_qs(Req), {ok, PostVals, Req2} = cowboy_req:body_qs(Req),

7
src/cowboy_req.erl
View file

@ -555,11 +555,10 @@ set_meta(Name, Value, Req=#http_req{meta=Meta}) ->
%% Request Body API. %% Request Body API.
%% @doc Return whether the request message has a body. %% @doc Return whether the request message has a body.
-spec has_body(Req) -> {boolean(), Req} when Req::req(). -spec has_body(cowboy_req:req()) -> boolean().
has_body(Req) -> has_body(Req) ->
Has = lists:keymember(<<"content-length">>, 1, Req#http_req.headers) orelse lists:keymember(<<"content-length">>, 1, Req#http_req.headers) orelse
lists:keymember(<<"transfer-encoding">>, 1, Req#http_req.headers), lists:keymember(<<"transfer-encoding">>, 1, Req#http_req.headers).
{Has, Req}.
%% @doc Return the request message body length, if known. %% @doc Return the request message body length, if known.
%% %%

4
test/http_handler_echo_body.erl
View file

@ -8,8 +8,8 @@ init({_, http}, Req, _) ->
{ok, Req, undefined}. {ok, Req, undefined}.
handle(Req, State) -> handle(Req, State) ->
{true, Req1} = cowboy_req:has_body(Req), true = cowboy_req:has_body(Req),
{ok, Body, Req2} = cowboy_req:body(Req1), {ok, Body, Req2} = cowboy_req:body(Req),
{Size, Req3} = cowboy_req:body_length(Req2), {Size, Req3} = cowboy_req:body_length(Req2),
Size = byte_size(Body), Size = byte_size(Body),
{ok, Req4} = cowboy_req:reply(200, [], Body, Req3), {ok, Req4} = cowboy_req:reply(200, [], Body, Req3),