umgeher/cowboy
0
Fork 0
mirror of https://github.com/ninenines/cowboy.git synced 2025-07-15 04:30:25 +00:00
Code Issues Wiki Activity

Make sure an incorrect port returns a 400 error

Browse source
This commit is contained in:
Loïc Hoguin 2012-12-22 16:45:04 +01:00
parent cc65a723d7
commit 7ff2a62585
2 changed files with 4 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

4
src/cowboy_protocol.erl
View file

@ -379,7 +379,9 @@ request(B, State=#state{transport=Transport}, M, P, Q, F, Version, Headers) ->
request(B, State, M, P, Q, F, Version, Headers, request(B, State, M, P, Q, F, Version, Headers,
<<>>, default_port(Transport:name())); <<>>, default_port(Transport:name()));
{_, RawHost} -> {_, RawHost} ->
case parse_host(RawHost, <<>>) of case catch parse_host(RawHost, <<>>) of
{'EXIT', _} ->
error_terminate(400, State);
{Host, undefined} -> {Host, undefined} ->
request(B, State, M, P, Q, F, Version, Headers, request(B, State, M, P, Q, F, Version, Headers,
Host, default_port(Transport:name())); Host, default_port(Transport:name()));

1
test/http_SUITE.erl
View file

@ -366,6 +366,7 @@ The document has moved
{400, "\r\n\r\n\r\n\r\n\r\n\r\n"}, {400, "\r\n\r\n\r\n\r\n\r\n\r\n"},
{400, "GET / HTTP/1.1\r\nHost: ninenines.eu\r\n\r\n"}, {400, "GET / HTTP/1.1\r\nHost: ninenines.eu\r\n\r\n"},
{400, "GET http://proxy/ HTTP/1.1\r\n\r\n"}, {400, "GET http://proxy/ HTTP/1.1\r\n\r\n"},
{400, "GET / HTTP/1.1\r\nHost: localhost:bad_port\r\n\r\n"},
{505, ResponsePacket}, {505, ResponsePacket},
{408, "GET / HTTP/1.1\r\n"}, {408, "GET / HTTP/1.1\r\n"},
{408, "GET / HTTP/1.1\r\nHost: localhost"}, {408, "GET / HTTP/1.1\r\nHost: localhost"},