umgeher/cowboy
0
Fork 0
mirror of https://github.com/ninenines/cowboy.git synced 2025-07-14 12:20:24 +00:00
Code Issues Wiki Activity

Make sure a path parsing error in the router gives a 400

Browse source
This commit is contained in:
Loïc Hoguin 2017-10-03 00:29:48 +02:00
parent b2bd9ccfb5
commit 6fc05a6d64
No known key found for this signature in database
GPG key ID: 71366FF21851DF03
2 changed files with 9 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

5
src/cowboy_router.erl
View file

@ -325,9 +325,8 @@ split_path(Path, Acc) ->
<< Segment:Pos/binary, _:8, Rest/bits >> = Path, << Segment:Pos/binary, _:8, Rest/bits >> = Path,
split_path(Rest, [Segment|Acc]) split_path(Rest, [Segment|Acc])
end end
catch catch error:_ ->
error:badarg -> badrequest
badrequest
end. end.
remove_dot_segments([], Acc) -> remove_dot_segments([], Acc) ->

7
test/misc_SUITE.erl
View file

@ -39,6 +39,13 @@ init_dispatch(_) ->
{"/", hello_h, []} {"/", hello_h, []}
]}]). ]}]).
router_invalid_path(Config) ->
doc("Ensure a path with invalid percent-encoded characters results in a 400."),
ConnPid = gun_open(Config),
Ref = gun:get(ConnPid, "/version/path/%\\u0016\\u0016/path"),
{response, _, 400, _} = gun:await(ConnPid, Ref),
ok.
set_env(Config) -> set_env(Config) ->
doc("Live replace a middleware environment value."), doc("Live replace a middleware environment value."),
ConnPid1 = gun_open(Config), ConnPid1 = gun_open(Config),