umgeher/cowboy
0
Fork 0
mirror of https://github.com/ninenines/cowboy.git synced 2025-07-16 05:00:24 +00:00
Code Issues Wiki Activity

Fix infinite loop on incomplete multipart body

Browse source 
I have amended a lot of changes from the original commit
to make it behave as expected, including returning a 400
error. LH
This commit is contained in:
Jeffrey Griffin 2017-05-16 14:50:01 -07:00 • committed by Loïc Hoguin
parent 292e732abf
commit 6460e9d2d2
No known key found for this signature in database
GPG key ID: 71366FF21851DF03
2 changed files with 48 additions and 9 deletions
Download patch file Download diff file Expand all files Collapse all files

31
test/req_SUITE.erl
View file

@ -475,6 +475,26 @@ do_multipart(Path, Config) ->
} = LargeHeaders,
ok.
multipart_error_empty(Config) ->
doc("Multipart request body is empty."),
%% We use an empty list as a body to make sure Gun knows
%% we want to send an empty body.
%% @todo This is a terrible hack. Improve Gun!
Body = [],
%% Ensure an empty body results in a 400 error.
{400, _} = do_body_error("POST", "/multipart", [
{<<"content-type">>, <<"multipart/mixed; boundary=deadbeef">>}
], Body, Config),
ok.
multipart_error_preamble_only(Config) ->
doc("Multipart request body only contains a preamble."),
%% Ensure an empty body results in a 400 error.
{400, _} = do_body_error("POST", "/multipart", [
{<<"content-type">>, <<"multipart/mixed; boundary=deadbeef">>}
], <<"Preamble.">>, Config),
ok.
multipart_error_headers(Config) ->
doc("Multipart request body with invalid part headers."),
ReqBody = [
@ -490,6 +510,17 @@ multipart_error_headers(Config) ->
%% The function to parse the multipart body currently does not crash,
%% as far as I can tell. There is therefore no test for it.
multipart_error_no_final_boundary(Config) ->
doc("Multipart request body with no final boundary."),
ReqBody = [
"--deadbeef\r\nContent-Type: text/plain\r\n\r\nCowboy is an HTTP server.\r\n"
],
%% Ensure parse errors result in a 400 response.
{400, _} = do_body_error("POST", "/multipart", [
{<<"content-type">>, <<"multipart/mixed; boundary=deadbeef">>}
], ReqBody, Config),
ok.
multipart_missing_boundary(Config) ->
doc("Multipart request body without a boundary in the media type."),
ReqBody = [