umgeher/cowboy
0
Fork 0
mirror of https://github.com/ninenines/cowboy.git synced 2025-07-14 20:30:23 +00:00
Code Issues Wiki Activity

Add a better error message when user callbacks are not exported

Browse source
This commit is contained in:
Loïc Hoguin 2012-11-29 14:33:45 +01:00
parent 6ec12f7ce8
commit 5f6b6b6f6d
3 changed files with 65 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

20
test/http_SUITE.erl
View file

@ -50,6 +50,8 @@
-export([pipeline/1]).
-export([rest_keepalive/1]).
-export([rest_keepalive_post/1]).
-export([rest_missing_get_callbacks/1]).
-export([rest_missing_put_callbacks/1]).
-export([rest_nodelete/1]).
-export([rest_resource_etags/1]).
-export([rest_resource_etags_if_none_match/1]).
@ -95,6 +97,8 @@ groups() ->
pipeline,
rest_keepalive,
rest_keepalive_post,
rest_missing_get_callbacks,
rest_missing_put_callbacks,
rest_nodelete,
rest_resource_etags,
rest_resource_etags_if_none_match,
@ -250,6 +254,8 @@ init_dispatch(Config) ->
{[<<"simple">>], rest_simple_resource, []},
{[<<"forbidden_post">>], rest_forbidden_resource, [true]},
{[<<"simple_post">>], rest_forbidden_resource, [false]},
{[<<"missing_get_callbacks">>], rest_missing_callbacks, []},
{[<<"missing_put_callbacks">>], rest_missing_callbacks, []},
{[<<"nodelete">>], rest_nodelete_resource, []},
{[<<"resetags">>], rest_resource_etags, []},
{[<<"loop_timeout">>], http_handler_loop_timeout, []},
@ -691,6 +697,20 @@ rest_keepalive_post_loop(Config, Client, forbidden_post, N) ->
= lists:keyfind(<<"connection">>, 1, RespHeaders),
rest_keepalive_post_loop(Config, Client3, simple_post, N - 1).
rest_missing_get_callbacks(Config) ->
Client = ?config(client, Config),
{ok, Client2} = cowboy_client:request(<<"GET">>,
build_url("/missing_get_callbacks", Config), Client),
{ok, 500, _, _} = cowboy_client:response(Client2).
rest_missing_put_callbacks(Config) ->
Client = ?config(client, Config),
{ok, Client2} = cowboy_client:request(<<"PUT">>,
build_url("/missing_put_callbacks", Config),
[{<<"content-type">>, <<"application/json">>}],
<<"{}">>, Client),
{ok, 500, _, _} = cowboy_client:response(Client2).
rest_nodelete(Config) ->
Client = ?config(client, Config),
{ok, Client2} = cowboy_client:request(<<"DELETE">>,

21
test/rest_missing_callbacks.erl Normal file
View file

@ -0,0 +1,21 @@
-module(rest_missing_callbacks).
-export([init/3]).
-export([allowed_methods/2]).
-export([content_types_accepted/2]).
-export([content_types_provided/2]).
init(_Transport, _Req, _Opts) ->
{upgrade, protocol, cowboy_rest}.
allowed_methods(Req, State) ->
{[<<"GET">>, <<"PUT">>], Req, State}.
content_types_accepted(Req, State) ->
{[
{<<"application/json">>, put_application_json}
], Req, State}.
content_types_provided(Req, State) ->
{[
{<<"text/plain">>, get_text_plain}
], Req, State}.