umgeher/cowboy
0
Fork 0
mirror of https://github.com/ninenines/cowboy.git synced 2025-07-14 12:20:24 +00:00
Code Issues Wiki Activity

Exit gracefully on {error,closed} when reading the PROXY header

Browse source 
LH: Simplified the test a little.
This commit is contained in:
Nelson Vides 2021-04-20 14:58:58 +02:00 • committed by Loïc Hoguin
parent f74b69c3ed
commit 5ef64557b5
No known key found for this signature in database
GPG key ID: 8A9DF795F6FED764
3 changed files with 42 additions and 14 deletions
Download patch file Download diff file Expand all files Collapse all files

24
test/proxy_header_SUITE.erl
View file

@ -71,6 +71,30 @@ init_dispatch() ->
%% Tests.
fail_gracefully_on_disconnect(Config) ->
doc("Probing a port must not generate a crash"),
{ok, Socket} = gen_tcp:connect("localhost", config(port, Config),
[binary, {active, false}, {packet, raw}]),
timer:sleep(50),
Pid = case config(type, Config) of
tcp -> ct_helper:get_remote_pid_tcp(Socket);
%% We connect to a TLS port using a TCP socket so we need
%% to first obtain the remote pid of the TCP socket, which
%% is a TLS socket on the server, and then get the real
%% remote pid from its state.
ssl -> ct_helper:get_remote_pid_tls_state(ct_helper:get_remote_pid_tcp(Socket))
end,
Ref = erlang:monitor(process, Pid),
gen_tcp:close(Socket),
receive
{'DOWN', Ref, process, Pid, {shutdown, closed}} ->
ok;
{'DOWN', Ref, process, Pid, Reason} ->
error(Reason)
after 500 ->
error(timeout)
end.
v1_proxy_header(Config) ->
doc("Confirm we can read the proxy header at the start of the connection."),
ProxyInfo = #{