umgeher/cowboy
0
Fork 0
mirror of https://github.com/ninenines/cowboy.git synced 2025-07-14 20:30:23 +00:00
Code Issues Wiki Activity

Accept sendfile tuple with 0 length in cowboy_req

Browse source 
This will result in no data being sent. It's simply easier to
do this than to have to handle 0 size cases in user code.
This commit is contained in:
Loïc Hoguin 2017-09-04 20:48:07 +02:00
parent 0995fc99e0
commit 4fd6e2f7cd
No known key found for this signature in database
GPG key ID: 71366FF21851DF03
4 changed files with 34 additions and 12 deletions
Download patch file Download diff file Expand all files Collapse all files

3
test/handlers/resp_h.erl
View file

@ -58,6 +58,9 @@ do(<<"resp_headers_empty">>, Req, Opts) ->
do(<<"set_resp_body">>, Req0, Opts) ->
Arg = cowboy_req:binding(arg, Req0),
Req1 = case Arg of
<<"sendfile0">> ->
AppFile = code:where_is_file("cowboy.app"),
cowboy_req:set_resp_body({sendfile, 0, 0, AppFile}, Req0);
<<"sendfile">> ->
AppFile = code:where_is_file("cowboy.app"),
cowboy_req:set_resp_body({sendfile, 0, filelib:file_size(AppFile), AppFile}, Req0);

21
test/req_SUITE.erl
View file

@ -509,6 +509,27 @@ set_resp_body(Config) ->
{200, _, AppFile} = do_get("/resp/set_resp_body/sendfile", Config),
ok.
set_resp_body_sendfile0(Config) ->
doc("Response using set_resp_body with a sendfile of length 0."),
Path = "/resp/set_resp_body/sendfile0",
ConnPid = gun_open(Config),
%% First request.
Ref1 = gun:get(ConnPid, Path, [{<<"accept-encoding">>, <<"gzip">>}]),
{response, IsFin, 200, _} = gun:await(ConnPid, Ref1),
{ok, <<>>} = case IsFin of
nofin -> gun:await_body(ConnPid, Ref1);
fin -> {ok, <<>>}
end,
%% Second request will confirm everything works as intended.
Ref2 = gun:get(ConnPid, Path, [{<<"accept-encoding">>, <<"gzip">>}]),
{response, IsFin, 200, _} = gun:await(ConnPid, Ref2),
{ok, <<>>} = case IsFin of
nofin -> gun:await_body(ConnPid, Ref2);
fin -> {ok, <<>>}
end,
gun:close(ConnPid),
ok.
has_resp_header(Config) ->
doc("Has response header?"),
{200, Headers, <<"OK">>} = do_get("/resp/has_resp_header", Config),