umgeher/cowboy
0
Fork 0
mirror of https://github.com/ninenines/cowboy.git synced 2025-07-14 04:10:24 +00:00
Code Issues Wiki Activity

Add WS compression test where only server sets client_max_window_bits

Browse source 
When the server has a non-default value configured and the client
doesn't send one the extension negotiation should fail.
This commit is contained in:
Jose M Perez 2021-10-07 14:21:49 +02:00 • committed by Loïc Hoguin
parent 7f739cad6d
commit 49061587be
No known key found for this signature in database
GPG key ID: 8A9DF795F6FED764
2 changed files with 16 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

2
rebar.config
View file

@ -1,4 +1,4 @@
{deps, [ {deps, [
{cowlib,".*",{git,"https://github.com/ninenines/cowlib","master"}},{ranch,".*",{git,"https://github.com/ninenines/ranch","1.8.0"}} {cowlib,".*",{git,"https://github.com/ninenines/cowlib","master"}},{ranch,".*",{git,"https://github.com/ninenines/ranch","1.8.x"}}
]}. ]}.
{erl_opts, [debug_info,warn_export_vars,warn_shadow_vars,warn_obsolete_guard,warn_missing_spec,warn_untyped_record]}. {erl_opts, [debug_info,warn_export_vars,warn_shadow_vars,warn_obsolete_guard,warn_missing_spec,warn_untyped_record]}.

15
test/ws_SUITE.erl
View file

@ -267,6 +267,21 @@ ws_deflate_opts_client_max_window_bits_override(Config) ->
= lists:keyfind("sec-websocket-extensions", 1, Headers2), = lists:keyfind("sec-websocket-extensions", 1, Headers2),
ok. ok.
%% @todo This might be better in an rfc7692_SUITE.
%%
%% 7.1.2.2
%% If a received extension negotiation offer doesn't have the
%% "client_max_window_bits" extension parameter, the corresponding
%% extension negotiation response to the offer MUST NOT include the
%% "client_max_window_bits" extension parameter.
ws_deflate_opts_client_max_window_bits_only_in_server(Config) ->
doc("Handler is configured with non-default client max window bits but "
"client doesn't send the parameter; compression is disabled."),
{ok, _, Headers} = do_handshake("/ws_deflate_opts?client_max_window_bits",
"Sec-WebSocket-Extensions: permessage-deflate\r\n", Config),
false = lists:keyfind("sec-websocket-extensions", 1, Headers),
ok.
ws_deflate_opts_server_context_takeover(Config) -> ws_deflate_opts_server_context_takeover(Config) ->
doc("Handler is configured with server context takeover enabled."), doc("Handler is configured with server context takeover enabled."),
{ok, _, Headers1} = do_handshake("/ws_deflate_opts?server_context_takeover", {ok, _, Headers1} = do_handshake("/ws_deflate_opts?server_context_takeover",