umgeher/cowboy
0
Fork 0
mirror of https://github.com/ninenines/cowboy.git synced 2025-07-14 12:20:24 +00:00
Code Issues Wiki Activity

Add preliminary support for trailers in responses

Browse source 
This depends on changes in Cowlib that are only available on
master.
This commit is contained in:
Loïc Hoguin 2017-11-15 14:58:49 +01:00
parent a1ad482eb4
commit 39baed6c80
No known key found for this signature in database
GPG key ID: 8A9DF795F6FED764
7 changed files with 120 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

34
test/req_SUITE.erl
View file

@ -841,6 +841,40 @@ stream_body_nofin(Config) ->
%% @todo Crash when calling stream_body after calling reply.
%% @todo Crash when calling stream_body before calling stream_reply.
stream_trailers(Config) ->
doc("Stream body followed by trailer headers."),
{200, RespHeaders, <<"Hello world!">>, [
{<<"grpc-status">>, <<"0">>}
]} = do_trailers("/resp/stream_trailers", Config),
{_, <<"grpc-status">>} = lists:keyfind(<<"trailer">>, 1, RespHeaders),
ok.
stream_trailers_no_te(Config) ->
doc("Stream body followed by trailer headers."),
ConnPid = gun_open(Config),
Ref = gun:get(ConnPid, "/resp/stream_trailers", [
{<<"accept-encoding">>, <<"gzip">>}
]),
{response, nofin, 200, RespHeaders} = gun:await(ConnPid, Ref),
{ok, RespBody} = gun:await_body(ConnPid, Ref),
gun:close(ConnPid).
do_trailers(Path, Config) ->
ConnPid = gun_open(Config),
Ref = gun:get(ConnPid, Path, [
{<<"accept-encoding">>, <<"gzip">>},
{<<"te">>, <<"trailers">>}
]),
{response, nofin, Status, RespHeaders} = gun:await(ConnPid, Ref),
{ok, RespBody, Trailers} = gun:await_body(ConnPid, Ref),
gun:close(ConnPid),
{Status, RespHeaders, do_decode(RespHeaders, RespBody), Trailers}.
%% @todo Crash when calling stream_trailers twice.
%% @todo Crash when calling stream_trailers after the fin flag has been set.
%% @todo Crash when calling stream_trailers after calling reply.
%% @todo Crash when calling stream_trailers before calling stream_reply.
%% Tests: Push.
%% @todo We want to crash when push is called after reply has been initiated.