umgeher/cowboy
0
Fork 0
mirror of https://github.com/ninenines/cowboy.git synced 2025-07-14 12:20:24 +00:00
Code Issues Wiki Activity

204 and 304 responses must not include a body

Browse source 
When calling cowboy_req:reply/4 with a body a crash will occur
resulting in a 500 response. When calling cowboy_req:stream_reply/2,3
and then attempting to send a body a crash will occur.
This commit is contained in:
Loïc Hoguin 2020-05-20 13:41:05 +02:00
parent 8337aca4d3
commit 39b2816255
No known key found for this signature in database
GPG key ID: 8A9DF795F6FED764
4 changed files with 47 additions and 18 deletions
Download patch file Download diff file Expand all files Collapse all files

15
test/handlers/resp_h.erl
View file

@ -181,6 +181,12 @@ do(<<"reply4">>, Req0, Opts) ->
<<"error">> ->
ct_helper:ignore(erlang, iolist_size, 1),
cowboy_req:reply(200, #{}, ok, Req0);
<<"204body">> ->
ct_helper:ignore(cowboy_req, reply, 4),
cowboy_req:reply(204, #{}, <<"OK">>, Req0);
<<"304body">> ->
ct_helper:ignore(cowboy_req, reply, 4),
cowboy_req:reply(304, #{}, <<"OK">>, Req0);
Status ->
cowboy_req:reply(binary_to_integer(Status), #{}, <<"OK">>, Req0)
end,
@ -199,8 +205,15 @@ do(<<"stream_reply2">>, Req0, Opts) ->
<<"204">> ->
Req = cowboy_req:stream_reply(204, Req0),
{ok, Req, Opts};
<<"304">> ->
<<"204body">> ->
ct_helper:ignore(cowboy_req, stream_body, 3),
Req = cowboy_req:stream_reply(204, Req0),
stream_body(Req),
{ok, Req, Opts};
<<"304body">> ->
ct_helper:ignore(cowboy_req, stream_body, 3),
Req = cowboy_req:stream_reply(304, Req0),
stream_body(Req),
{ok, Req, Opts};
Status ->
Req = cowboy_req:stream_reply(binary_to_integer(Status), Req0),