umgeher/cowboy
0
Fork 0
mirror of https://github.com/ninenines/cowboy.git synced 2025-07-14 12:20:24 +00:00
Code Issues Wiki Activity

204 and 304 responses must not include a body

Browse source 
When calling cowboy_req:reply/4 with a body a crash will occur
resulting in a 500 response. When calling cowboy_req:stream_reply/2,3
and then attempting to send a body a crash will occur.
This commit is contained in:
Loïc Hoguin 2020-05-20 13:41:05 +02:00
parent 8337aca4d3
commit 39b2816255
No known key found for this signature in database
GPG key ID: 8A9DF795F6FED764
4 changed files with 47 additions and 18 deletions
Download patch file Download diff file Expand all files Collapse all files

19
src/cowboy_req.erl
View file

@ -806,12 +806,16 @@ reply(Status, Headers, SendFile = {sendfile, _, Len, _}, Req)
}, SendFile, Req);
%% 204 responses must not include content-length. 304 responses may
%% but only when set explicitly. (RFC7230 3.3.1, RFC7230 3.3.2)
%% Neither status code must include a response body. (RFC7230 3.3)
reply(Status, Headers, Body, Req)
when Status =:= 204; Status =:= 304 ->
0 = iolist_size(Body),
do_reply(Status, Headers, Body, Req);
reply(Status= <<"204",_/bits>>, Headers, Body, Req) ->
reply(Status = <<"204",_/bits>>, Headers, Body, Req) ->
0 = iolist_size(Body),
do_reply(Status, Headers, Body, Req);
reply(Status= <<"304",_/bits>>, Headers, Body, Req) ->
reply(Status = <<"304",_/bits>>, Headers, Body, Req) ->
0 = iolist_size(Body),
do_reply(Status, Headers, Body, Req);
reply(Status, Headers, Body, Req)
when is_integer(Status); is_binary(Status) ->
@ -840,6 +844,17 @@ stream_reply(Status, Req) ->
-> Req when Req::req().
stream_reply(_, _, #{has_sent_resp := _}) ->
error(function_clause);
%% 204 and 304 responses must NOT send a body. We therefore
%% transform the call to a full response and expect the user
%% to NOT call stream_body/3 afterwards. (RFC7230 3.3)
stream_reply(Status = 204, Headers=#{}, Req) ->
reply(Status, Headers, <<>>, Req);
stream_reply(Status = <<"204",_/bits>>, Headers=#{}, Req) ->
reply(Status, Headers, <<>>, Req);
stream_reply(Status = 304, Headers=#{}, Req) ->
reply(Status, Headers, <<>>, Req);
stream_reply(Status = <<"304",_/bits>>, Headers=#{}, Req) ->
reply(Status, Headers, <<>>, Req);
stream_reply(Status, Headers=#{}, Req) when is_integer(Status); is_binary(Status) ->
cast({headers, Status, response_headers(Headers, Req)}, Req),
done_replying(Req, headers).