umgeher/cowboy
0
Fork 0
mirror of https://github.com/ninenines/cowboy.git synced 2025-07-14 20:30:23 +00:00
Code Issues Wiki Activity

Only send the window_update when Size - RemoteWindow > 0 to prevent over 2^31-1 limit.

Browse source
This commit is contained in:
Cola Cheng 2019-04-12 19:05:47 +08:00
parent d846827b2a
commit 34786b2c9e
1 changed files with 12 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

18
src/cowboy_http2.erl
View file

@ -574,12 +574,18 @@ commands(State0=#state{socket=Socket, transport=Transport, http2_machine=HTTP2Ma
commands(State, StreamID, Tail);
commands(State=#state{socket=Socket, transport=Transport, http2_machine=HTTP2Machine0},
StreamID, [{flow, Size}|Tail]) ->
Transport:send(Socket, [
cow_http2:window_update(Size),
cow_http2:window_update(StreamID, Size)
]),
HTTP2Machine1 = cow_http2_machine:update_window(Size, HTTP2Machine0),
HTTP2Machine = cow_http2_machine:update_window(StreamID, Size, HTTP2Machine1),
RemoteWindow = cow_http2_machine:get_window(HTTP2Machine0),
HTTP2Machine = case Size - RemoteWindow of
Diff when Diff > 0 ->
Transport:send(Socket, [
cow_http2:window_update(Diff),
cow_http2:window_update(StreamID, Diff)
]),
HTTP2Machine1 = cow_http2_machine:update_window(Diff, HTTP2Machine0),
cow_http2_machine:update_window(StreamID, Diff, HTTP2Machine1);
_ ->
HTTP2Machine0
end,
commands(State#state{http2_machine=HTTP2Machine}, StreamID, Tail);
%% Supervise a child process.
commands(State=#state{children=Children}, StreamID, [{spawn, Pid, Shutdown}|Tail]) ->