mirror of
https://github.com/ninenines/cowboy.git
synced 2025-07-14 04:10:24 +00:00
Reject responses with explicit set-cookie header
LH: The tests received a lot of fixes and tweaking.
I also reworded the error message to be more concise.
This commit is contained in:
geeksilva97
Loïc Hoguin
parent
1a175e7b56
commit
308045fd67
3 changed files with 83 additions and 0 deletions
|
|
@ -30,6 +30,10 @@ do(<<"set_resp_cookie4">>, Req0, Opts) ->
|
|||
do(<<"set_resp_header">>, Req0, Opts) ->
|
||||
Req = cowboy_req:set_resp_header(<<"content-type">>, <<"text/plain">>, Req0),
|
||||
{ok, cowboy_req:reply(200, #{}, "OK", Req), Opts};
|
||||
do(<<"set_resp_header_cookie">>, Req0, Opts) ->
|
||||
ct_helper:ignore(cowboy_req, set_resp_header, 3),
|
||||
Req = cowboy_req:set_resp_header(<<"set-cookie">>, <<"name=value">>, Req0),
|
||||
{ok, cowboy_req:reply(200, #{}, "OK", Req), Opts};
|
||||
do(<<"set_resp_header_server">>, Req0, Opts) ->
|
||||
Req = cowboy_req:set_resp_header(<<"server">>, <<"nginx">>, Req0),
|
||||
{ok, cowboy_req:reply(200, #{}, "OK", Req), Opts};
|
||||
|
|
@ -39,6 +43,12 @@ do(<<"set_resp_headers">>, Req0, Opts) ->
|
|||
<<"content-encoding">> => <<"compress">>
|
||||
}, Req0),
|
||||
{ok, cowboy_req:reply(200, #{}, "OK", Req), Opts};
|
||||
do(<<"set_resp_headers_cookie">>, Req0, Opts) ->
|
||||
ct_helper:ignore(cowboy_req, set_resp_headers, 2),
|
||||
Req = cowboy_req:set_resp_headers(#{
|
||||
<<"set-cookie">> => <<"name=value">>
|
||||
}, Req0),
|
||||
{ok, cowboy_req:reply(200, #{}, "OK", Req), Opts};
|
||||
do(<<"set_resp_headers_http11">>, Req0, Opts) ->
|
||||
Req = cowboy_req:set_resp_headers(#{
|
||||
<<"connection">> => <<"custom-header, close">>,
|
||||
|
|
@ -147,6 +157,9 @@ do(<<"inform3">>, Req0, Opts) ->
|
|||
<<"error">> ->
|
||||
ct_helper:ignore(cowboy_req, inform, 3),
|
||||
cowboy_req:inform(ok, Headers, Req0);
|
||||
<<"set_cookie">> ->
|
||||
ct_helper:ignore(cowboy_req, inform, 3),
|
||||
cowboy_req:inform(102, #{<<"set-cookie">> => <<"name=value">>}, Req0);
|
||||
<<"twice">> ->
|
||||
cowboy_req:inform(102, Headers, Req0),
|
||||
cowboy_req:inform(102, Headers, Req0);
|
||||
|
|
@ -179,6 +192,9 @@ do(<<"reply3">>, Req0, Opts) ->
|
|||
<<"error">> ->
|
||||
ct_helper:ignore(cowboy_req, reply, 4),
|
||||
cowboy_req:reply(200, ok, Req0);
|
||||
<<"set_cookie">> ->
|
||||
ct_helper:ignore(cowboy_req, reply, 4),
|
||||
cowboy_req:reply(200, #{<<"set-cookie">> => <<"name=value">>}, Req0);
|
||||
Status ->
|
||||
cowboy_req:reply(binary_to_integer(Status),
|
||||
#{<<"content-type">> => <<"text/plain">>}, Req0)
|
||||
|
|
@ -189,6 +205,9 @@ do(<<"reply4">>, Req0, Opts) ->
|
|||
<<"error">> ->
|
||||
ct_helper:ignore(erlang, iolist_size, 1),
|
||||
cowboy_req:reply(200, #{}, ok, Req0);
|
||||
<<"set_cookie">> ->
|
||||
ct_helper:ignore(cowboy_req, reply, 4),
|
||||
cowboy_req:reply(200, #{<<"set-cookie">> => <<"name=value">>}, <<"OK">>, Req0);
|
||||
<<"204body">> ->
|
||||
ct_helper:ignore(cowboy_req, do_reply_ensure_no_body, 4),
|
||||
cowboy_req:reply(204, #{}, <<"OK">>, Req0);
|
||||
|
|
@ -240,6 +259,9 @@ do(<<"stream_reply3">>, Req0, Opts) ->
|
|||
<<"error">> ->
|
||||
ct_helper:ignore(cowboy_req, stream_reply, 3),
|
||||
cowboy_req:stream_reply(200, ok, Req0);
|
||||
<<"set_cookie">> ->
|
||||
ct_helper:ignore(cowboy_req, stream_reply, 3),
|
||||
cowboy_req:stream_reply(200, #{<<"set-cookie">> => <<"name=value">>}, Req0);
|
||||
Status ->
|
||||
cowboy_req:stream_reply(binary_to_integer(Status),
|
||||
#{<<"content-type">> => <<"text/plain">>}, Req0)
|
||||
|
|
@ -395,6 +417,16 @@ do(<<"stream_trailers">>, Req0, Opts) ->
|
|||
<<"grpc-status">> => <<"0">>
|
||||
}, Req),
|
||||
{ok, Req, Opts};
|
||||
<<"set_cookie">> ->
|
||||
ct_helper:ignore(cowboy_req, stream_trailers, 2),
|
||||
Req = cowboy_req:stream_reply(200, #{
|
||||
<<"trailer">> => <<"set-cookie">>
|
||||
}, Req0),
|
||||
cowboy_req:stream_body(<<"Hello world!">>, nofin, Req),
|
||||
cowboy_req:stream_trailers(#{
|
||||
<<"set-cookie">> => <<"name=value">>
|
||||
}, Req),
|
||||
{ok, Req, Opts};
|
||||
_ ->
|
||||
Req = cowboy_req:stream_reply(200, #{
|
||||
<<"trailer">> => <<"grpc-status">>
|
||||
|
|
|
|||
|
|
@ -809,6 +809,8 @@ set_resp_header(Config) ->
|
|||
doc("Response using set_resp_header."),
|
||||
{200, Headers, <<"OK">>} = do_get("/resp/set_resp_header", Config),
|
||||
true = lists:keymember(<<"content-type">>, 1, Headers),
|
||||
%% The set-cookie header is special. set_resp_cookie must be used.
|
||||
{500, _, _} = do_get("/resp/set_resp_header_cookie", Config),
|
||||
ok.
|
||||
|
||||
set_resp_headers(Config) ->
|
||||
|
|
@ -816,6 +818,8 @@ set_resp_headers(Config) ->
|
|||
{200, Headers, <<"OK">>} = do_get("/resp/set_resp_headers", Config),
|
||||
true = lists:keymember(<<"content-type">>, 1, Headers),
|
||||
true = lists:keymember(<<"content-encoding">>, 1, Headers),
|
||||
%% The set-cookie header is special. set_resp_cookie must be used.
|
||||
{500, _, _} = do_get("/resp/set_resp_headers_cookie", Config),
|
||||
ok.
|
||||
|
||||
resp_header(Config) ->
|
||||
|
|
@ -893,6 +897,8 @@ inform3(Config) ->
|
|||
{102, Headers, 200, _, _} = do_get_inform("/resp/inform3/102", Config),
|
||||
{102, Headers, 200, _, _} = do_get_inform("/resp/inform3/binary", Config),
|
||||
{500, _} = do_get_inform("/resp/inform3/error", Config),
|
||||
%% The set-cookie header is special. set_resp_cookie must be used.
|
||||
{500, _} = do_get_inform("/resp/inform3/set_cookie", Config),
|
||||
{102, Headers, 200, _, _} = do_get_inform("/resp/inform3/twice", Config),
|
||||
%% @todo How to test this properly? This isn't enough.
|
||||
{200, _} = do_get_inform("/resp/inform3/after_reply", Config),
|
||||
|
|
@ -918,6 +924,8 @@ reply3(Config) ->
|
|||
{404, Headers3, _} = do_get("/resp/reply3/404", Config),
|
||||
true = lists:keymember(<<"content-type">>, 1, Headers3),
|
||||
{500, _, _} = do_get("/resp/reply3/error", Config),
|
||||
%% The set-cookie header is special. set_resp_cookie must be used.
|
||||
{500, _, _} = do_get("/resp/reply3/set_cookie", Config),
|
||||
ok.
|
||||
|
||||
reply4(Config) ->
|
||||
|
|
@ -926,6 +934,8 @@ reply4(Config) ->
|
|||
{201, _, <<"OK">>} = do_get("/resp/reply4/201", Config),
|
||||
{404, _, <<"OK">>} = do_get("/resp/reply4/404", Config),
|
||||
{500, _, _} = do_get("/resp/reply4/error", Config),
|
||||
%% The set-cookie header is special. set_resp_cookie must be used.
|
||||
{500, _, _} = do_get("/resp/reply4/set_cookie", Config),
|
||||
ok.
|
||||
|
||||
stream_reply2(Config) ->
|
||||
|
|
@ -975,6 +985,8 @@ stream_reply3(Config) ->
|
|||
{404, Headers3, Body} = do_get("/resp/stream_reply3/404", Config),
|
||||
true = lists:keymember(<<"content-type">>, 1, Headers3),
|
||||
{500, _, _} = do_get("/resp/stream_reply3/error", Config),
|
||||
%% The set-cookie header is special. set_resp_cookie must be used.
|
||||
{500, _, _} = do_get("/resp/stream_reply3/set_cookie", Config),
|
||||
ok.
|
||||
|
||||
stream_body_fin0(Config) ->
|
||||
|
|
@ -1154,6 +1166,27 @@ stream_trailers_no_te(Config) ->
|
|||
<<"Hello world!">> = do_decode(RespHeaders, RespBody),
|
||||
gun:close(ConnPid).
|
||||
|
||||
stream_trailers_set_cookie(Config) ->
|
||||
doc("Trying to send set-cookie in trailers should result in a crash."),
|
||||
ConnPid = gun_open(Config),
|
||||
Ref = gun:get(ConnPid, "/resp/stream_trailers/set_cookie", [
|
||||
{<<"accept-encoding">>, <<"gzip">>},
|
||||
{<<"te">>, <<"trailers">>}
|
||||
]),
|
||||
{response, nofin, 200, _} = gun:await(ConnPid, Ref, infinity),
|
||||
case config(protocol, Config) of
|
||||
http ->
|
||||
%% Trailers are not sent because of the stream error.
|
||||
{ok, _Body} = gun:await_body(ConnPid, Ref, infinity),
|
||||
{error, timeout} = gun:await_body(ConnPid, Ref, 1000),
|
||||
ok;
|
||||
http2 ->
|
||||
{error, {stream_error, {stream_error, internal_error, _}}}
|
||||
= gun:await_body(ConnPid, Ref, infinity),
|
||||
ok
|
||||
end,
|
||||
gun:close(ConnPid).
|
||||
|
||||
do_trailers(Path, Config) ->
|
||||
ConnPid = gun_open(Config),
|
||||
Ref = gun:get(ConnPid, Path, [
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue