umgeher/cowboy
0
Fork 0
mirror of https://github.com/ninenines/cowboy.git synced 2025-07-14 20:30:23 +00:00
Code Issues Wiki Activity

Remove cowboy_req:body/2

Browse source 
This function was badly thought out and would cause more harm
than good if used at all. Recommendation will be for people
who need to limit body length to check it beforehand or when
not possible to use the stream_body API.
This commit is contained in:
Loïc Hoguin 2012-12-26 18:51:41 +01:00
parent f401a84be6
commit 2690d1254c
1 changed files with 4 additions and 16 deletions
Download patch file Download diff file Expand all files Collapse all files

20
src/cowboy_req.erl
View file

@ -81,7 +81,6 @@
-export([stream_body/1]).
-export([skip_body/1]).
-export([body/1]).
-export([body/2]).
-export([body_qs/1]).
-export([multipart_data/1]).
-export([multipart_skip/1]).
@ -698,25 +697,14 @@ content_decode(ContentDecode, Data, Req) ->
%% @doc Return the full body sent with the request.
-spec body(Req) -> {ok, binary(), Req} | {error, atom()} when Req::req().
body(Req) ->
read_body(infinity, Req, <<>>).
body(Req, <<>>).
%% @doc Return the full body sent with the request as long as the body
%% length doesn't go over MaxLength.
%%
%% This is most useful to quickly be able to get the full body while
%% avoiding filling your memory with huge request bodies when you're
%% not expecting it.
-spec body(non_neg_integer() | infinity, Req)
-spec body(Req, binary())
-> {ok, binary(), Req} | {error, atom()} when Req::req().
body(MaxLength, Req) ->
read_body(MaxLength, Req, <<>>).
-spec read_body(non_neg_integer() | infinity, Req, binary())
-> {ok, binary(), Req} | {error, atom()} when Req::req().
read_body(MaxLength, Req, Acc) when MaxLength > byte_size(Acc) ->
body(Req, Acc) ->
case stream_body(Req) of
{ok, Data, Req2} ->
read_body(MaxLength, Req2, << Acc/binary, Data/binary >>);
body(Req2, << Acc/binary, Data/binary >>);
{done, Req2} ->
{ok, Acc, Req2};
{error, Reason} ->