umgeher/cowboy
0
Fork 0
mirror of https://github.com/ninenines/cowboy.git synced 2025-07-14 12:20:24 +00:00
Code Issues Wiki Activity

Add case for handling infinity for idle/request_timeout

Browse source 
Currently cowboy assumes that idle_timeout or request_timeout is
a number and always starts timers. Similar situation takes place
in case of preface_timeout for http2. This commit adds case for
handling infinity as a timeout, allowing to not start mentioned
timers.
This commit is contained in:
Bartek Walkowicz 2018-03-01 14:49:57 +01:00 • committed by Loïc Hoguin
parent f9092126fa
commit 2131709328
No known key found for this signature in database
GPG key ID: 8A9DF795F6FED764
4 changed files with 79 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

50
test/http_SUITE.erl
View file

@ -35,13 +35,16 @@ all() ->
{group, http_compress},
{group, https_compress},
{group, parse_host},
{group, request_timeout_infinity},
{group, idle_timeout_infinity},
{group, set_env},
{group, router_compile}
].
groups() ->
Tests = ct_helper:all(?MODULE) -- [
parse_host, set_env_dispatch, path_allow_colon
parse_host, set_env_dispatch, path_allow_colon,
request_timeout_infinity, idle_timeout_infinity
],
[
{http, [], Tests}, %% @todo parallel
@ -51,6 +54,12 @@ groups() ->
{parse_host, [], [
parse_host
]},
{request_timeout_infinity, [], [
request_timeout_infinity
]},
{idle_timeout_infinity, [], [
idle_timeout_infinity
]},
{set_env, [], [
set_env_dispatch
]},
@ -84,6 +93,22 @@ init_per_group(parse_host, Config) ->
}),
Port = ranch:get_port(parse_host),
[{type, tcp}, {protocol, http}, {port, Port}, {opts, []}|Config];
init_per_group(request_timeout_infinity, Config) ->
Ref = request_timeout_infinity,
{ok, Pid} = cowboy:start_clear(Ref, [{port, 0}], #{
env => #{dispatch => init_dispatch(Config)},
request_timeout => infinity
}),
Port = ranch:get_port(request_timeout_infinity),
[{pid, Pid}, {ref, Ref}, {type, tcp}, {protocol, http}, {port, Port}, {opts, []}|Config];
init_per_group(idle_timeout_infinity, Config) ->
Ref = idle_timeout_infinity,
{ok, Pid} = cowboy:start_clear(Ref, [{port, 0}], #{
env => #{dispatch => init_dispatch(Config)},
idle_timeout => infinity
}),
Port = ranch:get_port(idle_timeout_infinity),
[{pid, Pid}, {ref, Ref}, {type, tcp}, {protocol, http}, {port, Port}, {opts, []}|Config];
init_per_group(set_env, Config) ->
{ok, _} = cowboy:start_clear(set_env, [{port, 0}], #{
env => #{dispatch => []}
@ -746,3 +771,26 @@ te_identity(Config) ->
{response, nofin, 200, _} = gun:await(ConnPid, Ref),
{ok, Body} = gun:await_body(ConnPid, Ref),
ok.
request_timeout_infinity(Config) ->
Pid = config(pid, Config),
Ref = erlang:monitor(process, Pid),
_ = gun_open(Config),
receive
{'DOWN', Ref, process, Pid, Reason} ->
error(Reason)
after 1000 ->
ok
end.
idle_timeout_infinity(Config) ->
Pid = config(pid, Config),
Ref = erlang:monitor(process, Pid),
ConnPid = gun_open(Config),
gun:post(ConnPid, "/echo/body", [], <<"TEST">>),
receive
{'DOWN', Ref, process, Pid, Reason} ->
error(Reason)
after 1000 ->
ok
end.