umgeher/cowboy
0
Fork 0
mirror of https://github.com/ninenines/cowboy.git synced 2025-07-14 12:20:24 +00:00
Code Issues Wiki Activity

Remove duplicate /echo/body_qs tests from the old suite

Browse source
This commit is contained in:
Loïc Hoguin 2017-11-18 00:19:01 +01:00
parent bfe7f82812
commit 185d928e1a
No known key found for this signature in database
GPG key ID: 8A9DF795F6FED764
2 changed files with 0 additions and 47 deletions
Download patch file Download diff file Expand all files Collapse all files

15
test/http_SUITE.erl
View file

@ -105,7 +105,6 @@ init_dispatch(Config) ->
[{body, <<"A flameless dance does not equal a cycle">>}]},
{"/handler_errors", http_errors, []},
{"/echo/body", http_echo_body, []},
{"/echo/body_qs", http_body_qs, []},
{"/crash/content-length", input_crash_h, content_length},
{"/param_all", rest_param_all, []},
{"/bad_accept", rest_simple_resource, []},
@ -241,20 +240,6 @@ echo_body_max_length(Config) ->
{response, nofin, 413, _} = gun:await(ConnPid, Ref),
ok.
% check if body_qs echo's back results
echo_body_qs(Config) ->
ConnPid = gun_open(Config),
Ref = gun:post(ConnPid, "/echo/body_qs", [], <<"echo=67890">>),
{response, nofin, 200, _} = gun:await(ConnPid, Ref),
{ok, <<"67890">>} = gun:await_body(ConnPid, Ref),
ok.
echo_body_qs_max_length(Config) ->
ConnPid = gun_open(Config),
Ref = gun:post(ConnPid, "/echo/body_qs", [], << "echo=", 0:4000000/unit:8 >>),
{response, nofin, 413, _} = gun:await(ConnPid, Ref),
ok.
error_init_after_reply(Config) ->
ConnPid = gun_open(Config),
Ref = gun:get(ConnPid, "/handler_errors?case=init_after_reply"),

32
test/http_SUITE_data/http_body_qs.erl
View file

@ -1,32 +0,0 @@
%% Feel free to use, reuse and abuse the code in this file.
-module(http_body_qs).
-export([init/2]).
init(Req, Opts) ->
Method = cowboy_req:method(Req),
HasBody = cowboy_req:has_body(Req),
{ok, maybe_echo(Method, HasBody, Req), Opts}.
maybe_echo(<<"POST">>, true, Req) ->
try cowboy_req:read_urlencoded_body(Req) of
{ok, PostVals, Req2} ->
echo(proplists:get_value(<<"echo">>, PostVals), Req2)
catch _:_ ->
echo(badlength, Req)
end;
maybe_echo(<<"POST">>, false, Req) ->
cowboy_req:reply(400, #{}, <<"Missing body.">>, Req);
maybe_echo(_, _, Req) ->
%% Method not allowed.
cowboy_req:reply(405, Req).
echo(badlength, Req) ->
cowboy_req:reply(413, #{}, <<"POST body bigger than 16000 bytes">>, Req);
echo(undefined, Req) ->
cowboy_req:reply(400, #{}, <<"Missing echo parameter.">>, Req);
echo(Echo, Req) ->
cowboy_req:reply(200, #{
<<"content-type">> => <<"text/plain; charset=utf-8">>
}, Echo, Req).