umgeher/cowboy
0
Fork 0
mirror of https://github.com/ninenines/cowboy.git synced 2025-07-14 12:20:24 +00:00
Code Issues Wiki Activity

Add tests for rejecting streams depending on themselves

Browse source
This commit is contained in:
Loïc Hoguin 2018-04-29 20:32:36 +02:00
parent 84b4128d06
commit 17349fafc2
No known key found for this signature in database
GPG key ID: 8A9DF795F6FED764
1 changed files with 43 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

44
test/rfc7540_SUITE.erl
View file

@ -2335,7 +2335,49 @@ reject_streamid_lower(Config) ->
% timely fashion. Failure to do so could lead to a deadlock when
% critical frames, such as WINDOW_UPDATE, are not read and acted upon.
%% @todo Stream priorities. (RFC7540 5.3 5.3.x)
%% (RFC7540 5.3.1)
% Inside the dependency tree, a dependent stream SHOULD only be
% allocated resources if either all of the streams that it depends on
% (the chain of parent streams up to 0x0) are closed or it is not
% possible to make progress on them.
%% We reject all invalid HEADERS with a connection error because
%% we do not want to waste resources decoding them.
reject_self_dependent_stream_headers(Config) ->
doc("HEADERS frames opening a stream that depends on itself "
"must be rejected with a PROTOCOL_ERROR connection error. (RFC7540 5.3.1)"),
{ok, Socket} = do_handshake(Config),
%% Send a HEADERS frame with priority set to depend on itself.
ok = gen_tcp:send(Socket, << 5:24, 1:8,
0:2, 1:1, 0:4, 1:1, 0:1, 1:31, 0:1, 1:31, 0:8 >>),
%% Receive a PROTOCOL_ERROR connection error.
{ok, << _:24, 7:8, _:72, 1:32 >>} = gen_tcp:recv(Socket, 17, 6000),
ok.
%% We reject all invalid HEADERS with a connection error because
%% we do not want to waste resources decoding them.
reject_self_dependent_stream_headers_with_padding(Config) ->
doc("HEADERS frames opening a stream that depends on itself "
"must be rejected with a PROTOCOL_ERROR connection error. (RFC7540 5.3.1)"),
{ok, Socket} = do_handshake(Config),
%% Send a HEADERS frame with priority set to depend on itself.
ok = gen_tcp:send(Socket, << 6:24, 1:8,
0:2, 1:1, 0:1, 1:1, 0:2, 1:1, 0:1, 1:31, 0:8, 0:1, 1:31, 0:8 >>),
%% Receive a PROTOCOL_ERROR connection error.
{ok, << _:24, 7:8, _:72, 1:32 >>} = gen_tcp:recv(Socket, 17, 6000),
ok.
reject_self_dependent_stream_priority(Config) ->
doc("PRIORITY frames making a stream depend on itself "
"must be rejected with a PROTOCOL_ERROR stream error. (RFC7540 5.3.1)"),
{ok, Socket} = do_handshake(Config),
%% Send a PRIORITY frame making a stream depend on itself.
ok = gen_tcp:send(Socket, cow_http2:priority(1, shared, 1, 123)),
%% Receive a PROTOCOL_ERROR stream error.
{ok, << _:24, 3:8, _:8, 1:32, 1:32 >>} = gen_tcp:recv(Socket, 13, 6000),
ok.
%% @todo Stream priorities. (RFC7540 5.3.2 5.3.3 5.3.4 5.3.5)
%% (RFC7540 5.4.1)
% An endpoint that encounters a connection error SHOULD first send a