umgeher/cowboy
0
Fork 0
mirror of https://github.com/ninenines/cowboy.git synced 2025-07-14 12:20:24 +00:00
Code Issues Wiki Activity

Don't crash on errors while receiving headers; throw an error 500 instead.

Browse source 
The server shouldn't crash the request process when we have an error
while receiving headers. A case where this could happen is if the header
line is too long.

See also bfrog's report on ticket #3 on github.
This commit is contained in:
Loïc Hoguin 2011-04-07 00:54:32 +02:00
parent d8a2fcf258
commit 0fad6c6fde
1 changed files with 3 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

4
src/cowboy_http_protocol.erl
View file

@ -128,7 +128,9 @@ header({http_header, _I, Field, _R, Value}, Req, State) ->
header(http_eoh, #http_req{host=undefined}, State) -> header(http_eoh, #http_req{host=undefined}, State) ->
error_terminate(400, State); error_terminate(400, State);
header(http_eoh, Req, State) -> header(http_eoh, Req, State) ->
handler_init(Req, State). handler_init(Req, State);
header({http_error, _String}, _Req, State) ->
error_terminate(500, State).
-spec handler_init(Req::#http_req{}, State::#state{}) -> ok. -spec handler_init(Req::#http_req{}, State::#state{}) -> ok.
handler_init(Req, State=#state{ handler_init(Req, State=#state{