umgeher/cowboy
0
Fork 0
mirror of https://github.com/ninenines/cowboy.git synced 2025-07-14 20:30:23 +00:00
Code Issues Wiki Activity

Fix case insensitive filesystems in static_handler test suite

Browse source
This commit is contained in:
Loïc Hoguin 2018-11-19 19:45:47 +01:00
parent 66fd122c08
commit 031b421732
No known key found for this signature in database
GPG key ID: 8A9DF795F6FED764
1 changed files with 23 additions and 11 deletions
Download patch file Download diff file Expand all files Collapse all files

34
test/static_handler_SUITE.erl
View file

@ -70,11 +70,19 @@ init_per_suite(Config) ->
%% A special folder contains files of 1 character from 0 to 127. %% A special folder contains files of 1 character from 0 to 127.
CharDir = config(priv_dir, Config) ++ "/char", CharDir = config(priv_dir, Config) ++ "/char",
ok = filelib:ensure_dir(CharDir ++ "/file"), ok = filelib:ensure_dir(CharDir ++ "/file"),
Chars = lists:flatten([case file:write_file(CharDir ++ [$/, C], [C]) of Chars0 = lists:flatten([case file:write_file(CharDir ++ [$/, C], [C]) of
ok -> C; ok -> C;
{error, _} -> [] {error, _} -> []
end || C <- lists:seq(0, 127)]), end || C <- lists:seq(0, 127)]),
[{static_dir, StaticDir}, {char_dir, CharDir}, {chars, Chars}|Config]. %% Determine whether we are on a case insensitive filesystem and
%% remove uppercase characters in that case. On case insensitive
%% filesystems we end up overwriting the "A" file with the "a" contents.
{CaseSensitive, Chars} = case file:read_file(CharDir ++ "/A") of
{ok, <<"A">>} -> {true, Chars0};
{ok, <<"a">>} -> {false, Chars0 -- "ABCDEFGHIJKLMNOPQRSTUVWXYZ"}
end,
[{static_dir, StaticDir}, {char_dir, CharDir},
{chars, Chars}, {case_sensitive, CaseSensitive}|Config].
end_per_suite(Config) -> end_per_suite(Config) ->
%% Special directory. %% Special directory.
@ -871,18 +879,22 @@ range_request(Config) ->
unicode_basic_latin(Config) -> unicode_basic_latin(Config) ->
doc("Get a file with non-urlencoded characters from Unicode Basic Latin block."), doc("Get a file with non-urlencoded characters from Unicode Basic Latin block."),
_ = [case do_get("/char/" ++ [C], Config) of %% Excluding the dot which has a special meaning in URLs
{200, _, << C >>} -> ok; %% when they are the only content in a path segment,
Error -> exit({error, C, Error}) %% and is tested as part of filenames in other test cases.
end || C <- Chars0 =
%% Excluding the dot which has a special meaning in URLs
%% when they are the only content in a path segment,
%% and is tested as part of filenames in other test cases.
"abcdefghijklmnopqrstuvwxyz" "abcdefghijklmnopqrstuvwxyz"
"ABCDEFGHIJKLMNOPQRSTUVWXYZ" "ABCDEFGHIJKLMNOPQRSTUVWXYZ"
"0123456789" "0123456789"
":@-_~!$&'()*+,;=" ":@-_~!$&'()*+,;=",
], Chars = case config(case_sensitive, Config) of
false -> Chars0 -- "ABCDEFGHIJKLMNOPQRSTUVWXYZ";
true -> Chars0
end,
_ = [case do_get("/char/" ++ [C], Config) of
{200, _, << C >>} -> ok;
Error -> exit({error, C, Error})
end || C <- Chars],
ok. ok.
unicode_basic_error(Config) -> unicode_basic_error(Config) ->